public inbox for glibc-cvs@sourceware.org
help / color / mirror / Atom feed
* [glibc] Remove unused DATEMSK file for tst-getdate
@ 2023-06-09 14:26 Arjun Shankar
  0 siblings, 0 replies; only message in thread
From: Arjun Shankar @ 2023-06-09 14:26 UTC (permalink / raw)
  To: glibc-cvs

https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=5e8d1b0328a850c229146f40e18848728b104583

commit 5e8d1b0328a850c229146f40e18848728b104583
Author: Martin Coufal <mcoufal@redhat.com>
Date:   Fri Jun 9 13:58:04 2023 +0200

    Remove unused DATEMSK file for tst-getdate
    
    tst-getdate used to rely on an in-tree datemsk file that was
    subsequently replaced by a file created during test execution.  This
    commit removes the unused file and corresponding env-var and uses a more
    appropriate name for the temp file.
    Reviewed-by: Carlos O'Donell <carlos@redhat.com>

Diff:
---
 time/Makefile      | 1 -
 time/datemsk       | 2 --
 time/tst-getdate.c | 2 +-
 3 files changed, 1 insertion(+), 4 deletions(-)

diff --git a/time/Makefile b/time/Makefile
index 92bc3db315..1d2e667cad 100644
--- a/time/Makefile
+++ b/time/Makefile
@@ -104,7 +104,6 @@ CFLAGS-mktime.c += $(config-cflags-wno-ignored-attributes)
 # Don't warn about Y2k problem in strftime format string.
 CFLAGS-test_time.c += -Wno-format
 
-tst-getdate-ENV= DATEMSK=datemsk TZDIR=${common-objpfx}timezone/testdata
 test_time-ARGS= EST5EDT CST
 
 tst-tzname-ENV = TZDIR=${common-objpfx}timezone/testdata
diff --git a/time/datemsk b/time/datemsk
deleted file mode 100644
index 3dc4d417fe..0000000000
--- a/time/datemsk
+++ /dev/null
@@ -1,2 +0,0 @@
-%H:%M:%S %F
-%d-%m-%Y %T
diff --git a/time/tst-getdate.c b/time/tst-getdate.c
index cf97e220f7..4c9ed28d58 100644
--- a/time/tst-getdate.c
+++ b/time/tst-getdate.c
@@ -98,7 +98,7 @@ static const char datemskstr[] =
 static void
 do_prepare (int argc, char **argv)
 {
-  int fd = create_temp_file ("tst-chk1.", &datemsk);
+  int fd = create_temp_file ("tst-getdate.", &datemsk);
   xwrite (fd, datemskstr, sizeof (datemskstr) - 1);
 
   setenv ("DATEMSK", datemsk, 1);

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2023-06-09 14:26 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-06-09 14:26 [glibc] Remove unused DATEMSK file for tst-getdate Arjun Shankar

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).