public inbox for glibc-cvs@sourceware.org
help / color / mirror / Atom feed
* [glibc] io/tst-statvfs: fix statfs().f_type comparison test on some arches
@ 2023-08-15 15:08 Florian Weimer
  0 siblings, 0 replies; only message in thread
From: Florian Weimer @ 2023-08-15 15:08 UTC (permalink / raw)
  To: glibc-cvs

https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=8c4e46337f2ef324f5af9863a962f070fd796cc1

commit 8c4e46337f2ef324f5af9863a962f070fd796cc1
Author: наб <nabijaczleweli@nabijaczleweli.xyz>
Date:   Tue Aug 15 15:07:59 2023 +0200

    io/tst-statvfs: fix statfs().f_type comparison test on some arches
    
    On i686 f_type is an i32 so the test fails when that has the top bit set.
    
    Explicitly cast to u32.
    
    Signed-off-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz>
    Reviewed-by: Florian Weimer <fweimer@redhat.com>

Diff:
---
 io/tst-statvfs.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/io/tst-statvfs.c b/io/tst-statvfs.c
index f3097ce1a8..fb23733667 100644
--- a/io/tst-statvfs.c
+++ b/io/tst-statvfs.c
@@ -16,7 +16,7 @@ do_test (int argc, char *argv[])
       struct statfs stf;
       TEST_COMPARE (statvfs (argv[i], &st), 0);
       TEST_COMPARE (statfs (argv[i], &stf), 0);
-      TEST_COMPARE (st.f_type, stf.f_type);
+      TEST_COMPARE (st.f_type, (unsigned int) stf.f_type);
       printf ("%s: free: %llu, mandatory: %s, tp=%x\n", argv[i],
               (unsigned long long int) st.f_bfree,
 #ifdef ST_MANDLOCK

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2023-08-15 15:08 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-08-15 15:08 [glibc] io/tst-statvfs: fix statfs().f_type comparison test on some arches Florian Weimer

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).