public inbox for glibc-cvs@sourceware.org
help / color / mirror / Atom feed
* [glibc] resolv: free only initialized items from gai pool
@ 2023-11-20 14:03 Florian Weimer
  0 siblings, 0 replies; only message in thread
From: Florian Weimer @ 2023-11-20 14:03 UTC (permalink / raw)
  To: glibc-cvs

https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=f2aaf18af50109b0982723bdf4e0a3bca2f8d3d6

commit f2aaf18af50109b0982723bdf4e0a3bca2f8d3d6
Author: Jan Palus <jpalus@fastmail.com>
Date:   Mon Oct 30 19:57:01 2023 +0100

    resolv: free only initialized items from gai pool
    
    pool_max_size denotes total allocated rows in pool but possibly not yet
    initialized. it's pool_size that represents number of actually occupied
    rows hence use it when freeing pool to avoid freeing random addresses.
    
    Signed-off-by: Jan Palus <jpalus@fastmail.com>
    Reviewed-by: Florian Weimer <fweimer@redhat.com>

Diff:
---
 resolv/gai_misc.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/resolv/gai_misc.c b/resolv/gai_misc.c
index d02bd7ed23..266ed6931c 100644
--- a/resolv/gai_misc.c
+++ b/resolv/gai_misc.c
@@ -1,4 +1,5 @@
 /* Copyright (C) 2001-2023 Free Software Foundation, Inc.
+   Copyright The GNU Toolchain Authors.
    This file is part of the GNU C Library.
 
    The GNU C Library is free software; you can redistribute it and/or
@@ -442,7 +443,7 @@ __gai_freemem (void)
 {
   size_t row;
 
-  for (row = 0; row < pool_max_size; ++row)
+  for (row = 0; row < pool_size; ++row)
     free (pool[row]);
 
   free (pool);

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2023-11-20 14:03 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-11-20 14:03 [glibc] resolv: free only initialized items from gai pool Florian Weimer

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).