public inbox for glibc-cvs@sourceware.org
help / color / mirror / Atom feed
* [glibc] aarch64: correct CFI in rawmemchr (bug 31113)
@ 2023-12-05 11:49 Andreas Schwab
  0 siblings, 0 replies; only message in thread
From: Andreas Schwab @ 2023-12-05 11:49 UTC (permalink / raw)
  To: glibc-cvs

https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=3f798427884fa57770e8e2291cf58d5918254bb5

commit 3f798427884fa57770e8e2291cf58d5918254bb5
Author: Andreas Schwab <schwab@suse.de>
Date:   Thu Nov 23 18:23:46 2023 +0100

    aarch64: correct CFI in rawmemchr (bug 31113)
    
    The .cfi_return_column directive changes the return column for the whole
    FDE range.  But the actual intent is to tell the unwinder that the value
    in x30 (lr) now resides in x15 after the move, and that is expressed by
    the .cfi_register directive.

Diff:
---
 sysdeps/aarch64/rawmemchr.S | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sysdeps/aarch64/rawmemchr.S b/sysdeps/aarch64/rawmemchr.S
index efc4b7007b..1fff094215 100644
--- a/sysdeps/aarch64/rawmemchr.S
+++ b/sysdeps/aarch64/rawmemchr.S
@@ -31,7 +31,7 @@ ENTRY (__rawmemchr)
 
 L(do_strlen):
 	mov	x15, x30
-	cfi_return_column (x15)
+	cfi_register (x30, x15)
 	mov	x14, x0
 	bl	__strlen
 	add	x0, x14, x0

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2023-12-05 11:49 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-12-05 11:49 [glibc] aarch64: correct CFI in rawmemchr (bug 31113) Andreas Schwab

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).