public inbox for glibc-cvs@sourceware.org help / color / mirror / Atom feed
From: Adhemerval Zanella <azanella@sourceware.org> To: glibc-cvs@sourceware.org Subject: [glibc/azanella/clang] math: Only build tests for _Complex __int128 iff compiler supports it Date: Thu, 21 Dec 2023 18:55:42 +0000 (GMT) [thread overview] Message-ID: <20231221185542.81DF33858292@sourceware.org> (raw) https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=8eeaf9038e5cc4337615cedcbd09c0ed4b1713bd commit 8eeaf9038e5cc4337615cedcbd09c0ed4b1713bd Author: Adhemerval Zanella <adhemerval.zanella@linaro.org> Date: Thu Mar 24 14:24:08 2022 -0300 math: Only build tests for _Complex __int128 iff compiler supports it clang fails building test-tgmath3-atan2.c: error: '_Complex __int128' is invalid _Complex __int128 var__Complex___int128 __attribute__ ((unused)); since it does not support _Complex with __int128. So disable the test in such case. Diff: --- configure | 29 +++++++++++++++++++++++++++++ configure.ac | 17 +++++++++++++++++ math/Makefile | 2 +- math/gen-tgmath-tests.py | 38 +++++++++++++++++++++++++++++--------- 4 files changed, 76 insertions(+), 10 deletions(-) diff --git a/configure b/configure index a811663fe4..3075261273 100755 --- a/configure +++ b/configure @@ -7388,6 +7388,35 @@ printf "%s\n" "$libc_cv_cc_float_store" >&6; } config_vars="$config_vars config-cflags-float-store = $libc_cv_cc_float_store" +{ printf "%s\n" "$as_me:${as_lineno-$LINENO}: checking whether compiler supports _Complex with __int128" >&5 +printf %s "checking whether compiler supports _Complex with __int128... " >&6; } +if test ${libc_cv_complex_int128+y} +then : + printf %s "(cached) " >&6 +else $as_nop + cat > conftest.c <<EOF +#ifndef __SIZEOF_INT128__ +# error "__int128 not supported" +#endif +_Complex __int128 var; +EOF +libc_cv_complex_int128=no +if { ac_try='${CC-cc} $CFLAGS $CPPFLAGS -c conftest.c 1>&5' + { { eval echo "\"\$as_me\":${as_lineno-$LINENO}: \"$ac_try\""; } >&5 + (eval $ac_try) 2>&5 + ac_status=$? + printf "%s\n" "$as_me:${as_lineno-$LINENO}: \$? = $ac_status" >&5 + test $ac_status = 0; }; } +then + libc_cv_complex_int128=yes +fi +rm -f conftest* +fi +{ printf "%s\n" "$as_me:${as_lineno-$LINENO}: result: $libc_cv_complex_int128" >&5 +printf "%s\n" "$libc_cv_complex_int128" >&6; } +config_vars="$config_vars +config-complex-int128 = $libc_cv_complex_int128" + { printf "%s\n" "$as_me:${as_lineno-$LINENO}: checking if $CC accepts -fno-tree-loop-distribute-patterns with \ __attribute__ ((__optimize__))" >&5 printf %s "checking if $CC accepts -fno-tree-loop-distribute-patterns with \ diff --git a/configure.ac b/configure.ac index 1f9d8b6e5e..a6e05cf585 100644 --- a/configure.ac +++ b/configure.ac @@ -1488,6 +1488,23 @@ LIBC_TRY_CC_OPTION([-Werror -ffloat-store], LIBC_CONFIG_VAR([config-cflags-float-store], [$libc_cv_cc_float_store]) +AC_CACHE_CHECK([whether compiler supports _Complex with __int128], + [libc_cv_complex_int128], [dnl +cat > conftest.c <<EOF +#ifndef __SIZEOF_INT128__ +# error "__int128 not supported" +#endif +_Complex __int128 var; +EOF +libc_cv_complex_int128=no +if AC_TRY_COMMAND([${CC-cc} $CFLAGS $CPPFLAGS -c conftest.c 1>&AS_MESSAGE_LOG_FD]) +then + libc_cv_complex_int128=yes +fi +rm -f conftest*]) +LIBC_CONFIG_VAR([config-complex-int128], + [$libc_cv_complex_int128]) + AC_CACHE_CHECK(if $CC accepts -fno-tree-loop-distribute-patterns with \ __attribute__ ((__optimize__)), libc_cv_cc_loop_to_function, [dnl cat > conftest.c <<EOF diff --git a/math/Makefile b/math/Makefile index 85a9cb3026..346cd67f8f 100644 --- a/math/Makefile +++ b/math/Makefile @@ -396,7 +396,7 @@ $(tgmath3-macro-tests:%=$(objpfx)%.o): CFLAGS += -fno-builtin $(foreach m,$(tgmath3-macros),\ $(objpfx)test-tgmath3-$(m).c): $(objpfx)test-tgmath3-%.c: \ gen-tgmath-tests.py - $(PYTHON) gen-tgmath-tests.py $* > $@ + $(PYTHON) gen-tgmath-tests.py --complex-int128 $(config-complex-int128) $* > $@ # Verify that the list of supported macros is in sync between the # Makefile and gen-tgmath-tests.py. diff --git a/math/gen-tgmath-tests.py b/math/gen-tgmath-tests.py index 0882c7341a..e16ba0b0b0 100755 --- a/math/gen-tgmath-tests.py +++ b/math/gen-tgmath-tests.py @@ -53,6 +53,7 @@ # supported on any given configuration of glibc, the MANT_DIG value # uniquely determines the format. +import argparse import string import sys @@ -182,7 +183,7 @@ class Type(object): return self.name @staticmethod - def init_types(): + def init_types(complex_int128): """Initialize all the known types.""" Type.create_type('_Float16', 'f16', 'FLT16_MANT_DIG', complex_name='__CFLOAT16', @@ -219,9 +220,11 @@ class Type(object): Type.create_type('long long int', integer=True) Type.create_type('unsigned long long int', integer=True) Type.create_type('__int128', integer=True, - condition='defined __SIZEOF_INT128__') + condition='defined __SIZEOF_INT128__', + complex_ok=complex_int128) Type.create_type('unsigned __int128', integer=True, - condition='defined __SIZEOF_INT128__') + condition='defined __SIZEOF_INT128__', + complex_ok=complex_int128) Type.create_type('enum e', integer=True, complex_ok=False) Type.create_type('_Bool', integer=True, complex_ok=False) Type.create_type('bit_field', integer=True, complex_ok=False) @@ -834,15 +837,32 @@ class Tests(object): print('error: macro list mismatch') sys.exit(1) -def main(): +def get_parser(): + def strbool(string): + return True if string.lower() == 'yes' else False + + parser = argparse.ArgumentParser(description=__doc__) + parser.add_argument('--complex-int128', dest='complex_int128', + help='Generate tests for _Complex __int128', + type=strbool) + parser.add_argument('--check-list', action='store_true', + help='Verify that the list of supported macros') + parser.add_argument('macro', + help='macro to test', + nargs='*') + return parser + +def main(argv): """The main entry point.""" - Type.init_types() + parser = get_parser() + opts = parser.parse_args(argv) + Type.init_types(True if opts.complex_int128 == 'yes' else False) t = Tests() - if sys.argv[1] == 'check-list': + if opts.check_list: macro = None - macro_list = sys.argv[2:] + macro_list = opts.macro else: - macro = sys.argv[1] + macro = opts.macro macro_list = [] t.add_all_tests(macro) if macro: @@ -851,4 +871,4 @@ def main(): t.check_macro_list(macro_list) if __name__ == '__main__': - main() + main(sys.argv[1:])
next reply other threads:[~2023-12-21 18:55 UTC|newest] Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-12-21 18:55 Adhemerval Zanella [this message] -- strict thread matches above, loose matches on Subject: below -- 2024-04-17 20:09 Adhemerval Zanella 2024-04-02 15:55 Adhemerval Zanella 2024-02-09 17:33 Adhemerval Zanella 2024-02-07 14:08 Adhemerval Zanella 2024-01-29 17:59 Adhemerval Zanella 2023-09-28 17:53 Adhemerval Zanella 2023-08-30 12:38 Adhemerval Zanella 2023-02-09 19:50 Adhemerval Zanella 2022-10-28 17:43 Adhemerval Zanella 2022-10-04 13:01 Adhemerval Zanella
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20231221185542.81DF33858292@sourceware.org \ --to=azanella@sourceware.org \ --cc=glibc-cvs@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).