public inbox for glibc-cvs@sourceware.org
help / color / mirror / Atom feed
From: Adhemerval Zanella <azanella@sourceware.org>
To: glibc-cvs@sourceware.org
Subject: [glibc] math: Fix test-fenv.c feupdateenv tests
Date: Wed, 10 Jan 2024 11:57:07 +0000 (GMT)	[thread overview]
Message-ID: <20240110115707.D03C23858D38@sourceware.org> (raw)

https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=497e4d503025c794a771d2c124123178f557623a

commit 497e4d503025c794a771d2c124123178f557623a
Author: Adhemerval Zanella <adhemerval.zanella@linaro.org>
Date:   Tue Jan 9 16:40:33 2024 -0300

    math: Fix test-fenv.c feupdateenv tests
    
    The feupdateenv tests added by 802aef27b2 do not restore the floating
    point mask, which might keep some floating point exception enabled and
    thus make the feupdateenv_single_test raise an unexpected signal.
    
    Checked on x86_64-linux-gnu and aarch64-linux-gnu (on Apple M1 trapping
    is supported).
    Reviewed-by: Szabolcs Nagy <szabolcs.nagy@arm.com>

Diff:
---
 math/test-fenv.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/math/test-fenv.c b/math/test-fenv.c
index 9db6789e64..8d39181b14 100644
--- a/math/test-fenv.c
+++ b/math/test-fenv.c
@@ -659,6 +659,7 @@ static void
 feupdate_single_test (const char *flag_name, int fe_exc)
 {
   feenv_nomask_test (flag_name, fe_exc, feupdateenv);
+  fesetenv (FE_DFL_ENV);
   feenv_mask_test (flag_name, fe_exc, feupdateenv);
 }
 #endif

                 reply	other threads:[~2024-01-10 11:57 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240110115707.D03C23858D38@sourceware.org \
    --to=azanella@sourceware.org \
    --cc=glibc-cvs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).