public inbox for glibc-cvs@sourceware.org
help / color / mirror / Atom feed
* [glibc] math: Fix test-fenv.c feupdateenv tests
@ 2024-01-10 11:57 Adhemerval Zanella
0 siblings, 0 replies; only message in thread
From: Adhemerval Zanella @ 2024-01-10 11:57 UTC (permalink / raw)
To: glibc-cvs
https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=497e4d503025c794a771d2c124123178f557623a
commit 497e4d503025c794a771d2c124123178f557623a
Author: Adhemerval Zanella <adhemerval.zanella@linaro.org>
Date: Tue Jan 9 16:40:33 2024 -0300
math: Fix test-fenv.c feupdateenv tests
The feupdateenv tests added by 802aef27b2 do not restore the floating
point mask, which might keep some floating point exception enabled and
thus make the feupdateenv_single_test raise an unexpected signal.
Checked on x86_64-linux-gnu and aarch64-linux-gnu (on Apple M1 trapping
is supported).
Reviewed-by: Szabolcs Nagy <szabolcs.nagy@arm.com>
Diff:
---
math/test-fenv.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/math/test-fenv.c b/math/test-fenv.c
index 9db6789e64..8d39181b14 100644
--- a/math/test-fenv.c
+++ b/math/test-fenv.c
@@ -659,6 +659,7 @@ static void
feupdate_single_test (const char *flag_name, int fe_exc)
{
feenv_nomask_test (flag_name, fe_exc, feupdateenv);
+ fesetenv (FE_DFL_ENV);
feenv_mask_test (flag_name, fe_exc, feupdateenv);
}
#endif
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2024-01-10 11:57 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-01-10 11:57 [glibc] math: Fix test-fenv.c feupdateenv tests Adhemerval Zanella
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).