public inbox for
help / color / mirror / Atom feed
* [glibc] stdlib: Fix heapsort for cases with exactly two elements
@ 2024-01-16 15:20 Adhemerval Zanella
  0 siblings, 0 replies; only message in thread
From: Adhemerval Zanella @ 2024-01-16 15:20 UTC (permalink / raw)
  To: glibc-cvs;h=74d2731a5fb2676b64092bc25e7f193db1b17b2b

commit 74d2731a5fb2676b64092bc25e7f193db1b17b2b
Author: Kuan-Wei Chiu <>
Date:   Tue Jan 16 10:16:56 2024 +0800

    stdlib: Fix heapsort for cases with exactly two elements
    When malloc fails to allocate a buffer and falls back to heapsort, the
    current heapsort implementation does not perform sorting when there are
    exactly two elements. Heapsort is now skipped only when there is
    exactly one element.
    Signed-off-by: Kuan-Wei Chiu <>
    Reviewed-by: Adhemerval Zanella  <>

 stdlib/qsort.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/stdlib/qsort.c b/stdlib/qsort.c
index b29882388e..45af8da80c 100644
--- a/stdlib/qsort.c
+++ b/stdlib/qsort.c
@@ -162,7 +162,7 @@ get_swap_type (void *const pbase, size_t size)
 static void
 heapsort_r (void *base, size_t n, size_t size, __compar_d_fn_t cmp, void *arg)
-  if (n <= 1)
+  if (n == 0)
   enum swap_type_t swap_type = get_swap_type (base, size);

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2024-01-16 15:20 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-01-16 15:20 [glibc] stdlib: Fix heapsort for cases with exactly two elements Adhemerval Zanella

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).