public inbox for glibc-cvs@sourceware.org help / color / mirror / Atom feed
From: Adhemerval Zanella <azanella@sourceware.org> To: glibc-cvs@sourceware.org Subject: [glibc/azanella/clang] timezone: Fix clang operator precedence warning Date: Mon, 29 Jan 2024 17:56:30 +0000 (GMT) [thread overview] Message-ID: <20240129175631.08D1F3858431@sourceware.org> (raw) https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=bee7e6dac37002da6aa254b6e6a779e5930495ff commit bee7e6dac37002da6aa254b6e6a779e5930495ff Author: Adhemerval Zanella <adhemerval.zanella@linaro.org> Date: Thu Mar 10 16:44:45 2022 -0300 timezone: Fix clang operator precedence warning clang issues: zdump.c:669:7: error: operator '?:' has lower precedence than '&'; '&' will be evaluated first [-Werror,-Wbitwise-conditional-parentheses] ? (delta(&tm, &lotm) == t - lot which is exactly what the code intendes. Instead of adding a warning suppress, place parentheses around the '&' expression. Diff: --- timezone/zdump.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/timezone/zdump.c b/timezone/zdump.c index b532fe3eae..bfc01faffa 100644 --- a/timezone/zdump.c +++ b/timezone/zdump.c @@ -665,7 +665,7 @@ hunt(timezone_t tz, char *name, time_t lot, time_t hit) else if (t >= hit) --t; tm_ok = my_localtime_rz(tz, &t, &tm) != NULL; - if (lotm_ok & tm_ok + if ((lotm_ok & tm_ok) ? (delta(&tm, &lotm) == t - lot && tm.tm_isdst == lotm.tm_isdst && strcmp(abbr(&tm), ab) == 0)
next reply other threads:[~2024-01-29 17:56 UTC|newest] Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top 2024-01-29 17:56 Adhemerval Zanella [this message] -- strict thread matches above, loose matches on Subject: below -- 2024-04-02 15:52 Adhemerval Zanella 2024-02-09 17:30 Adhemerval Zanella 2024-02-07 14:06 Adhemerval Zanella 2023-12-21 18:53 Adhemerval Zanella 2023-09-28 17:51 Adhemerval Zanella 2023-08-30 12:36 Adhemerval Zanella 2023-02-09 19:48 Adhemerval Zanella 2022-10-28 17:41 Adhemerval Zanella 2022-10-04 12:59 Adhemerval Zanella 2022-06-09 21:19 Adhemerval Zanella 2022-06-09 13:16 Adhemerval Zanella 2022-06-03 14:05 Adhemerval Zanella 2022-05-13 14:19 Adhemerval Zanella 2022-05-12 19:33 Adhemerval Zanella 2022-05-10 18:23 Adhemerval Zanella 2022-04-29 14:03 Adhemerval Zanella 2022-04-04 12:53 Adhemerval Zanella 2022-03-31 19:06 Adhemerval Zanella 2022-03-29 20:29 Adhemerval Zanella 2022-03-16 18:02 Adhemerval Zanella 2022-03-15 18:40 Adhemerval Zanella 2022-03-11 17:24 Adhemerval Zanella
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20240129175631.08D1F3858431@sourceware.org \ --to=azanella@sourceware.org \ --cc=glibc-cvs@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).