public inbox for glibc-cvs@sourceware.org
help / color / mirror / Atom feed
* [glibc] misc: tst-poll: Proper synchronize with child before sending the signal
@ 2024-02-01 12:45 Adhemerval Zanella
0 siblings, 0 replies; only message in thread
From: Adhemerval Zanella @ 2024-02-01 12:45 UTC (permalink / raw)
To: glibc-cvs
https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=26d01172f5c3f3b912ecf21ebb911eb5351bba4d
commit 26d01172f5c3f3b912ecf21ebb911eb5351bba4d
Author: Adhemerval Zanella <adhemerval.zanella@linaro.org>
Date: Fri Jan 26 08:23:41 2024 -0300
misc: tst-poll: Proper synchronize with child before sending the signal
When running the testsuite in parallel, for instance running make -j
$(nproc) check, occasionally tst-epoll fails with a timeout. It happens
because it sometimes takes a bit more than 10ms for the process to get
cloned and blocked by the syscall. In that case the signal is
sent to early, and the test fails with a timeout.
Checked on x86_64-linux-gnu.
Diff:
---
sysdeps/unix/sysv/linux/tst-epoll.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/sysdeps/unix/sysv/linux/tst-epoll.c b/sysdeps/unix/sysv/linux/tst-epoll.c
index 3b38beae6e..545f506faa 100644
--- a/sysdeps/unix/sysv/linux/tst-epoll.c
+++ b/sysdeps/unix/sysv/linux/tst-epoll.c
@@ -22,7 +22,7 @@
#include <support/support.h>
#include <support/xsignal.h>
#include <support/xunistd.h>
-#include <support/xtime.h>
+#include <support/process_state.h>
#include <stdlib.h>
#include <sys/epoll.h>
@@ -97,8 +97,8 @@ test_epoll_basic (epoll_wait_check_t epoll_wait_check)
xclose (fds[0][0]);
xclose (fds[1][1]);
- /* Wait some time so child is blocked on the syscall. */
- nanosleep (&(struct timespec) {0, 10000000}, NULL);
+ /* Wait until child is blocked on epoll_wait. */
+ support_process_state_wait (p, support_process_state_sleeping);
TEST_COMPARE (kill (p, SIGUSR1), 0);
int e = epoll_wait_check (efd, &event, 1, 500000000, &ss);
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2024-02-01 12:45 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-02-01 12:45 [glibc] misc: tst-poll: Proper synchronize with child before sending the signal Adhemerval Zanella
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).