public inbox for glibc-cvs@sourceware.org
help / color / mirror / Atom feed
* [glibc/azanella/clang] stdlib: Remove -Wmaybe-uninitialized supression on setenv.c
@ 2024-02-09 17:28 Adhemerval Zanella
  0 siblings, 0 replies; 7+ messages in thread
From: Adhemerval Zanella @ 2024-02-09 17:28 UTC (permalink / raw)
  To: glibc-cvs

https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=f006074a1ca6c642e9879be37c2f3467c6a6bdf4

commit f006074a1ca6c642e9879be37c2f3467c6a6bdf4
Author: Adhemerval Zanella <adhemerval.zanella@linaro.org>
Date:   Wed Sep 13 16:55:27 2023 -0300

    stdlib: Remove -Wmaybe-uninitialized supression on setenv.c
    
    It is not required on current supported gcc.

Diff:
---
 stdlib/setenv.c | 13 ++-----------
 1 file changed, 2 insertions(+), 11 deletions(-)

diff --git a/stdlib/setenv.c b/stdlib/setenv.c
index e2164371ad..a21ffed19f 100644
--- a/stdlib/setenv.c
+++ b/stdlib/setenv.c
@@ -19,13 +19,6 @@
 # include <config.h>
 #endif
 
-/* Pacify GCC; see the commentary about VALLEN below.  This is needed
-   at least through GCC 4.9.2.  Pacify GCC for the entire file, as
-   there seems to be no way to pacify GCC selectively, only for the
-   place where it's needed.  Do not use DIAG_IGNORE_NEEDS_COMMENT
-   here, as it's not defined yet.  */
-#pragma GCC diagnostic ignored "-Wmaybe-uninitialized"
-
 #include <errno.h>
 #if !_LIBC
 # if !defined errno && !defined HAVE_ERRNO_DECL
@@ -121,10 +114,8 @@ __add_to_environ (const char *name, const char *value, const char *combined,
 
   /* Compute lengths before locking, so that the critical section is
      less of a performance bottleneck.  VALLEN is needed only if
-     COMBINED is null (unfortunately GCC is not smart enough to deduce
-     this; see the #pragma at the start of this file).  Testing
-     COMBINED instead of VALUE causes setenv (..., NULL, ...)  to dump
-     core now instead of corrupting memory later.  */
+     COMBINED is null.  Testing COMBINED instead of VALUE causes setenv
+     (..., NULL, ...) to dump core now instead of corrupting memory later.  */
   const size_t namelen = strlen (name);
   size_t vallen;
   if (combined == NULL)

^ permalink raw reply	[flat|nested] 7+ messages in thread

* [glibc/azanella/clang] stdlib: Remove -Wmaybe-uninitialized supression on setenv.c
@ 2024-04-17 20:04 Adhemerval Zanella
  0 siblings, 0 replies; 7+ messages in thread
From: Adhemerval Zanella @ 2024-04-17 20:04 UTC (permalink / raw)
  To: glibc-cvs

https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=a7df44378e63916194c430146ebc274725032016

commit a7df44378e63916194c430146ebc274725032016
Author: Adhemerval Zanella <adhemerval.zanella@linaro.org>
Date:   Wed Sep 13 16:55:27 2023 -0300

    stdlib: Remove -Wmaybe-uninitialized supression on setenv.c
    
    It is not required on current supported gcc.

Diff:
---
 stdlib/setenv.c | 13 ++-----------
 1 file changed, 2 insertions(+), 11 deletions(-)

diff --git a/stdlib/setenv.c b/stdlib/setenv.c
index e2164371ad..a21ffed19f 100644
--- a/stdlib/setenv.c
+++ b/stdlib/setenv.c
@@ -19,13 +19,6 @@
 # include <config.h>
 #endif
 
-/* Pacify GCC; see the commentary about VALLEN below.  This is needed
-   at least through GCC 4.9.2.  Pacify GCC for the entire file, as
-   there seems to be no way to pacify GCC selectively, only for the
-   place where it's needed.  Do not use DIAG_IGNORE_NEEDS_COMMENT
-   here, as it's not defined yet.  */
-#pragma GCC diagnostic ignored "-Wmaybe-uninitialized"
-
 #include <errno.h>
 #if !_LIBC
 # if !defined errno && !defined HAVE_ERRNO_DECL
@@ -121,10 +114,8 @@ __add_to_environ (const char *name, const char *value, const char *combined,
 
   /* Compute lengths before locking, so that the critical section is
      less of a performance bottleneck.  VALLEN is needed only if
-     COMBINED is null (unfortunately GCC is not smart enough to deduce
-     this; see the #pragma at the start of this file).  Testing
-     COMBINED instead of VALUE causes setenv (..., NULL, ...)  to dump
-     core now instead of corrupting memory later.  */
+     COMBINED is null.  Testing COMBINED instead of VALUE causes setenv
+     (..., NULL, ...) to dump core now instead of corrupting memory later.  */
   const size_t namelen = strlen (name);
   size_t vallen;
   if (combined == NULL)

^ permalink raw reply	[flat|nested] 7+ messages in thread

* [glibc/azanella/clang] stdlib: Remove -Wmaybe-uninitialized supression on setenv.c
@ 2024-04-02 15:50 Adhemerval Zanella
  0 siblings, 0 replies; 7+ messages in thread
From: Adhemerval Zanella @ 2024-04-02 15:50 UTC (permalink / raw)
  To: glibc-cvs

https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=c9346a2f294438c2f53be58916967b1fce0afac8

commit c9346a2f294438c2f53be58916967b1fce0afac8
Author: Adhemerval Zanella <adhemerval.zanella@linaro.org>
Date:   Wed Sep 13 16:55:27 2023 -0300

    stdlib: Remove -Wmaybe-uninitialized supression on setenv.c
    
    It is not required on current supported gcc.

Diff:
---
 stdlib/setenv.c | 13 ++-----------
 1 file changed, 2 insertions(+), 11 deletions(-)

diff --git a/stdlib/setenv.c b/stdlib/setenv.c
index e2164371ad..a21ffed19f 100644
--- a/stdlib/setenv.c
+++ b/stdlib/setenv.c
@@ -19,13 +19,6 @@
 # include <config.h>
 #endif
 
-/* Pacify GCC; see the commentary about VALLEN below.  This is needed
-   at least through GCC 4.9.2.  Pacify GCC for the entire file, as
-   there seems to be no way to pacify GCC selectively, only for the
-   place where it's needed.  Do not use DIAG_IGNORE_NEEDS_COMMENT
-   here, as it's not defined yet.  */
-#pragma GCC diagnostic ignored "-Wmaybe-uninitialized"
-
 #include <errno.h>
 #if !_LIBC
 # if !defined errno && !defined HAVE_ERRNO_DECL
@@ -121,10 +114,8 @@ __add_to_environ (const char *name, const char *value, const char *combined,
 
   /* Compute lengths before locking, so that the critical section is
      less of a performance bottleneck.  VALLEN is needed only if
-     COMBINED is null (unfortunately GCC is not smart enough to deduce
-     this; see the #pragma at the start of this file).  Testing
-     COMBINED instead of VALUE causes setenv (..., NULL, ...)  to dump
-     core now instead of corrupting memory later.  */
+     COMBINED is null.  Testing COMBINED instead of VALUE causes setenv
+     (..., NULL, ...) to dump core now instead of corrupting memory later.  */
   const size_t namelen = strlen (name);
   size_t vallen;
   if (combined == NULL)

^ permalink raw reply	[flat|nested] 7+ messages in thread

* [glibc/azanella/clang] stdlib: Remove -Wmaybe-uninitialized supression on setenv.c
@ 2024-02-07 14:03 Adhemerval Zanella
  0 siblings, 0 replies; 7+ messages in thread
From: Adhemerval Zanella @ 2024-02-07 14:03 UTC (permalink / raw)
  To: glibc-cvs

https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=8bc11395602856e6419f23401f85f336b3f7b456

commit 8bc11395602856e6419f23401f85f336b3f7b456
Author: Adhemerval Zanella <adhemerval.zanella@linaro.org>
Date:   Wed Sep 13 16:55:27 2023 -0300

    stdlib: Remove -Wmaybe-uninitialized supression on setenv.c
    
    It is not required on current supported gcc.

Diff:
---
 stdlib/setenv.c | 13 ++-----------
 1 file changed, 2 insertions(+), 11 deletions(-)

diff --git a/stdlib/setenv.c b/stdlib/setenv.c
index e2164371ad..a21ffed19f 100644
--- a/stdlib/setenv.c
+++ b/stdlib/setenv.c
@@ -19,13 +19,6 @@
 # include <config.h>
 #endif
 
-/* Pacify GCC; see the commentary about VALLEN below.  This is needed
-   at least through GCC 4.9.2.  Pacify GCC for the entire file, as
-   there seems to be no way to pacify GCC selectively, only for the
-   place where it's needed.  Do not use DIAG_IGNORE_NEEDS_COMMENT
-   here, as it's not defined yet.  */
-#pragma GCC diagnostic ignored "-Wmaybe-uninitialized"
-
 #include <errno.h>
 #if !_LIBC
 # if !defined errno && !defined HAVE_ERRNO_DECL
@@ -121,10 +114,8 @@ __add_to_environ (const char *name, const char *value, const char *combined,
 
   /* Compute lengths before locking, so that the critical section is
      less of a performance bottleneck.  VALLEN is needed only if
-     COMBINED is null (unfortunately GCC is not smart enough to deduce
-     this; see the #pragma at the start of this file).  Testing
-     COMBINED instead of VALUE causes setenv (..., NULL, ...)  to dump
-     core now instead of corrupting memory later.  */
+     COMBINED is null.  Testing COMBINED instead of VALUE causes setenv
+     (..., NULL, ...) to dump core now instead of corrupting memory later.  */
   const size_t namelen = strlen (name);
   size_t vallen;
   if (combined == NULL)

^ permalink raw reply	[flat|nested] 7+ messages in thread

* [glibc/azanella/clang] stdlib: Remove -Wmaybe-uninitialized supression on setenv.c
@ 2024-01-29 17:54 Adhemerval Zanella
  0 siblings, 0 replies; 7+ messages in thread
From: Adhemerval Zanella @ 2024-01-29 17:54 UTC (permalink / raw)
  To: glibc-cvs

https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=ca1005e07f1fe2929c11ea6685f3cd2c09708a0a

commit ca1005e07f1fe2929c11ea6685f3cd2c09708a0a
Author: Adhemerval Zanella <adhemerval.zanella@linaro.org>
Date:   Wed Sep 13 16:55:27 2023 -0300

    stdlib: Remove -Wmaybe-uninitialized supression on setenv.c
    
    It is not required on current supported gcc.

Diff:
---
 stdlib/setenv.c | 13 ++-----------
 1 file changed, 2 insertions(+), 11 deletions(-)

diff --git a/stdlib/setenv.c b/stdlib/setenv.c
index e2164371ad..a21ffed19f 100644
--- a/stdlib/setenv.c
+++ b/stdlib/setenv.c
@@ -19,13 +19,6 @@
 # include <config.h>
 #endif
 
-/* Pacify GCC; see the commentary about VALLEN below.  This is needed
-   at least through GCC 4.9.2.  Pacify GCC for the entire file, as
-   there seems to be no way to pacify GCC selectively, only for the
-   place where it's needed.  Do not use DIAG_IGNORE_NEEDS_COMMENT
-   here, as it's not defined yet.  */
-#pragma GCC diagnostic ignored "-Wmaybe-uninitialized"
-
 #include <errno.h>
 #if !_LIBC
 # if !defined errno && !defined HAVE_ERRNO_DECL
@@ -121,10 +114,8 @@ __add_to_environ (const char *name, const char *value, const char *combined,
 
   /* Compute lengths before locking, so that the critical section is
      less of a performance bottleneck.  VALLEN is needed only if
-     COMBINED is null (unfortunately GCC is not smart enough to deduce
-     this; see the #pragma at the start of this file).  Testing
-     COMBINED instead of VALUE causes setenv (..., NULL, ...)  to dump
-     core now instead of corrupting memory later.  */
+     COMBINED is null.  Testing COMBINED instead of VALUE causes setenv
+     (..., NULL, ...) to dump core now instead of corrupting memory later.  */
   const size_t namelen = strlen (name);
   size_t vallen;
   if (combined == NULL)

^ permalink raw reply	[flat|nested] 7+ messages in thread

* [glibc/azanella/clang] stdlib: Remove -Wmaybe-uninitialized supression on setenv.c
@ 2023-12-21 18:50 Adhemerval Zanella
  0 siblings, 0 replies; 7+ messages in thread
From: Adhemerval Zanella @ 2023-12-21 18:50 UTC (permalink / raw)
  To: glibc-cvs

https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=2140ff6aaf1f4117b624d21683e0d33eca96028a

commit 2140ff6aaf1f4117b624d21683e0d33eca96028a
Author: Adhemerval Zanella <adhemerval.zanella@linaro.org>
Date:   Wed Sep 13 16:55:27 2023 -0300

    stdlib: Remove -Wmaybe-uninitialized supression on setenv.c
    
    It is not required on current supported gcc.

Diff:
---
 stdlib/setenv.c | 13 ++-----------
 1 file changed, 2 insertions(+), 11 deletions(-)

diff --git a/stdlib/setenv.c b/stdlib/setenv.c
index cc71287fcc..873a699200 100644
--- a/stdlib/setenv.c
+++ b/stdlib/setenv.c
@@ -19,13 +19,6 @@
 # include <config.h>
 #endif
 
-/* Pacify GCC; see the commentary about VALLEN below.  This is needed
-   at least through GCC 4.9.2.  Pacify GCC for the entire file, as
-   there seems to be no way to pacify GCC selectively, only for the
-   place where it's needed.  Do not use DIAG_IGNORE_NEEDS_COMMENT
-   here, as it's not defined yet.  */
-#pragma GCC diagnostic ignored "-Wmaybe-uninitialized"
-
 #include <errno.h>
 #if !_LIBC
 # if !defined errno && !defined HAVE_ERRNO_DECL
@@ -121,10 +114,8 @@ __add_to_environ (const char *name, const char *value, const char *combined,
 
   /* Compute lengths before locking, so that the critical section is
      less of a performance bottleneck.  VALLEN is needed only if
-     COMBINED is null (unfortunately GCC is not smart enough to deduce
-     this; see the #pragma at the start of this file).  Testing
-     COMBINED instead of VALUE causes setenv (..., NULL, ...)  to dump
-     core now instead of corrupting memory later.  */
+     COMBINED is null.  Testing COMBINED instead of VALUE causes setenv
+     (..., NULL, ...) to dump core now instead of corrupting memory later.  */
   const size_t namelen = strlen (name);
   size_t vallen;
   if (combined == NULL)

^ permalink raw reply	[flat|nested] 7+ messages in thread

* [glibc/azanella/clang] stdlib: Remove -Wmaybe-uninitialized supression on setenv.c
@ 2023-09-28 17:48 Adhemerval Zanella
  0 siblings, 0 replies; 7+ messages in thread
From: Adhemerval Zanella @ 2023-09-28 17:48 UTC (permalink / raw)
  To: glibc-cvs

https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=fa16c0a05390efcc6035c3bd945322d03faea7ce

commit fa16c0a05390efcc6035c3bd945322d03faea7ce
Author: Adhemerval Zanella <adhemerval.zanella@linaro.org>
Date:   Wed Sep 13 16:55:27 2023 -0300

    stdlib: Remove -Wmaybe-uninitialized supression on setenv.c
    
    It is not required on current supported gcc.

Diff:
---
 stdlib/setenv.c | 13 ++-----------
 1 file changed, 2 insertions(+), 11 deletions(-)

diff --git a/stdlib/setenv.c b/stdlib/setenv.c
index cc71287fcc..873a699200 100644
--- a/stdlib/setenv.c
+++ b/stdlib/setenv.c
@@ -19,13 +19,6 @@
 # include <config.h>
 #endif
 
-/* Pacify GCC; see the commentary about VALLEN below.  This is needed
-   at least through GCC 4.9.2.  Pacify GCC for the entire file, as
-   there seems to be no way to pacify GCC selectively, only for the
-   place where it's needed.  Do not use DIAG_IGNORE_NEEDS_COMMENT
-   here, as it's not defined yet.  */
-#pragma GCC diagnostic ignored "-Wmaybe-uninitialized"
-
 #include <errno.h>
 #if !_LIBC
 # if !defined errno && !defined HAVE_ERRNO_DECL
@@ -121,10 +114,8 @@ __add_to_environ (const char *name, const char *value, const char *combined,
 
   /* Compute lengths before locking, so that the critical section is
      less of a performance bottleneck.  VALLEN is needed only if
-     COMBINED is null (unfortunately GCC is not smart enough to deduce
-     this; see the #pragma at the start of this file).  Testing
-     COMBINED instead of VALUE causes setenv (..., NULL, ...)  to dump
-     core now instead of corrupting memory later.  */
+     COMBINED is null.  Testing COMBINED instead of VALUE causes setenv
+     (..., NULL, ...) to dump core now instead of corrupting memory later.  */
   const size_t namelen = strlen (name);
   size_t vallen;
   if (combined == NULL)

^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2024-04-17 20:04 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-02-09 17:28 [glibc/azanella/clang] stdlib: Remove -Wmaybe-uninitialized supression on setenv.c Adhemerval Zanella
  -- strict thread matches above, loose matches on Subject: below --
2024-04-17 20:04 Adhemerval Zanella
2024-04-02 15:50 Adhemerval Zanella
2024-02-07 14:03 Adhemerval Zanella
2024-01-29 17:54 Adhemerval Zanella
2023-12-21 18:50 Adhemerval Zanella
2023-09-28 17:48 Adhemerval Zanella

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).