public inbox for glibc-cvs@sourceware.org
help / color / mirror / Atom feed
* [glibc] x86/cet: fix shadow stack test scripts
@ 2024-02-12 14:50 H.J. Lu
  0 siblings, 0 replies; only message in thread
From: H.J. Lu @ 2024-02-12 14:50 UTC (permalink / raw)
  To: glibc-cvs

https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=155bb9d036646138348fee0ac045de601811e0c5

commit 155bb9d036646138348fee0ac045de601811e0c5
Author: Michael Jeanson <mjeanson@efficios.com>
Date:   Mon Feb 5 15:22:39 2024 -0500

    x86/cet: fix shadow stack test scripts
    
    Some shadow stack test scripts use the '==' operator with the 'test'
    command to validate exit codes resulting in the following error:
    
      sysdeps/x86_64/tst-shstk-legacy-1e.sh: 31: test: 139: unexpected operator
    
    The '==' operator is invalid for the 'test' command, use '-eq' like the
    previous call to 'test'.
    
    Signed-off-by: Michael Jeanson <mjeanson@efficios.com>
    Reviewed-by: H.J. Lu <hjl.tools@gmail.com>

Diff:
---
 sysdeps/x86_64/tst-shstk-legacy-1e-static.sh | 2 +-
 sysdeps/x86_64/tst-shstk-legacy-1e.sh        | 2 +-
 sysdeps/x86_64/tst-shstk-legacy-1g.sh        | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/sysdeps/x86_64/tst-shstk-legacy-1e-static.sh b/sysdeps/x86_64/tst-shstk-legacy-1e-static.sh
index 46f1233757..0a9a164a3e 100755
--- a/sysdeps/x86_64/tst-shstk-legacy-1e-static.sh
+++ b/sysdeps/x86_64/tst-shstk-legacy-1e-static.sh
@@ -26,7 +26,7 @@ ${common_objpfx}elf/tst-shstk-legacy-1e-static
 status=$?
 if test $status -eq 77; then
   exit 77
-elif test $status == 139; then
+elif test $status -eq 139; then
   exit 0
 else
   exit 1
diff --git a/sysdeps/x86_64/tst-shstk-legacy-1e.sh b/sysdeps/x86_64/tst-shstk-legacy-1e.sh
index 31212453d9..3dec5623e4 100755
--- a/sysdeps/x86_64/tst-shstk-legacy-1e.sh
+++ b/sysdeps/x86_64/tst-shstk-legacy-1e.sh
@@ -28,7 +28,7 @@ ${test_program_prefix} \
 status=$?
 if test $status -eq 77; then
   exit 77
-elif test $status == 139; then
+elif test $status -eq 139; then
   exit 0
 else
   exit 1
diff --git a/sysdeps/x86_64/tst-shstk-legacy-1g.sh b/sysdeps/x86_64/tst-shstk-legacy-1g.sh
index e84087068e..249831e816 100755
--- a/sysdeps/x86_64/tst-shstk-legacy-1g.sh
+++ b/sysdeps/x86_64/tst-shstk-legacy-1g.sh
@@ -28,7 +28,7 @@ ${test_program_prefix} \
 status=$?
 if test $status -eq 77; then
   exit 77
-elif test $status == 139; then
+elif test $status -eq 139; then
   exit 0
 else
   exit 1

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2024-02-12 14:50 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-02-12 14:50 [glibc] x86/cet: fix shadow stack test scripts H.J. Lu

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).