public inbox for glibc-cvs@sourceware.org help / color / mirror / Atom feed
From: Adhemerval Zanella <azanella@sourceware.org> To: glibc-cvs@sourceware.org Subject: [glibc/azanella/clang] i386: Disable some tests on clang Date: Tue, 2 Apr 2024 16:00:02 +0000 (GMT) [thread overview] Message-ID: <20240402160002.610BD385801D@sourceware.org> (raw) https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=38831688eaebab0bce550d1a40fc20c8961c7d7e commit 38831688eaebab0bce550d1a40fc20c8961c7d7e Author: Adhemerval Zanella <adhemerval.zanella@linaro.org> Date: Fri Jul 28 09:34:03 2023 -0300 i386: Disable some tests on clang clang generated R_I386_PC32 instead of R_386_PLT32 for static ifoo calls, which triggers an ld issues where it can not link non-PIC and PIC objects. This seems to be a clang bug. Diff: --- elf/ifuncmain9.c | 5 +++++ sysdeps/x86/tst-ifunc-isa-1.c | 5 +++++ sysdeps/x86/tst-ifunc-isa-2.c | 4 ++++ 3 files changed, 14 insertions(+) diff --git a/elf/ifuncmain9.c b/elf/ifuncmain9.c index a13020dc6d..ed9c5a5d86 100644 --- a/elf/ifuncmain9.c +++ b/elf/ifuncmain9.c @@ -23,6 +23,7 @@ # include <stdbool.h> # include <stdio.h> # include <libc-diag.h> +# include <support/test-driver.h> /* Do not use the test framework, so that the process setup is not disturbed. */ @@ -57,6 +58,9 @@ DIAG_POP_NEEDS_COMMENT_CLANG; int main (void) { +#if defined __clang__ && defined __i386__ + return EXIT_UNSUPPORTED; +#else bool errors = false; if (implementation_called != 0) @@ -93,4 +97,5 @@ main (void) } return errors; +#endif } diff --git a/sysdeps/x86/tst-ifunc-isa-1.c b/sysdeps/x86/tst-ifunc-isa-1.c index 44726576f1..276efc0572 100644 --- a/sysdeps/x86/tst-ifunc-isa-1.c +++ b/sysdeps/x86/tst-ifunc-isa-1.c @@ -17,14 +17,19 @@ <https://www.gnu.org/licenses/>. */ #include <stdlib.h> +#include <support/test-driver.h> #include "tst-ifunc-isa.h" static int do_test (void) { +#if defined __clang__ && defined __i386__ + return EXIT_UNSUPPORTED; +#else enum isa value = foo (); enum isa expected = get_isa (); return value == expected ? EXIT_SUCCESS : EXIT_FAILURE; +#endif } #include <support/test-driver.c> diff --git a/sysdeps/x86/tst-ifunc-isa-2.c b/sysdeps/x86/tst-ifunc-isa-2.c index 156c649807..130169b614 100644 --- a/sysdeps/x86/tst-ifunc-isa-2.c +++ b/sysdeps/x86/tst-ifunc-isa-2.c @@ -23,12 +23,16 @@ static int do_test (void) { +#if defined __clang__ && defined __i386__ + return EXIT_UNSUPPORTED; +#else /* CPU must support SSE2. */ if (!__builtin_cpu_supports ("sse2")) return EXIT_UNSUPPORTED; enum isa value = foo (); /* All ISAs, but SSE2, are disabled by tunables. */ return value == sse2 ? EXIT_SUCCESS : EXIT_FAILURE; +#endif } #include <support/test-driver.c>
next reply other threads:[~2024-04-02 16:00 UTC|newest] Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top 2024-04-02 16:00 Adhemerval Zanella [this message] -- strict thread matches above, loose matches on Subject: below -- 2024-04-17 20:13 Adhemerval Zanella 2024-02-09 17:38 Adhemerval Zanella 2024-02-07 14:13 Adhemerval Zanella 2024-01-29 18:04 Adhemerval Zanella 2023-12-21 19:00 Adhemerval Zanella 2023-09-28 17:58 Adhemerval Zanella 2023-08-30 12:43 Adhemerval Zanella
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20240402160002.610BD385801D@sourceware.org \ --to=azanella@sourceware.org \ --cc=glibc-cvs@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).