public inbox for glibc-cvs@sourceware.org
help / color / mirror / Atom feed
* [glibc] Use crtbeginT.o and crtend.o for non-PIE static executables
@ 2024-04-08 16:26 H.J. Lu
  0 siblings, 0 replies; only message in thread
From: H.J. Lu @ 2024-04-08 16:26 UTC (permalink / raw)
  To: glibc-cvs

https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=727aacfd667c026762b9aaa1a3a293f815edebba

commit 727aacfd667c026762b9aaa1a3a293f815edebba
Author: H.J. Lu <hjl.tools@gmail.com>
Date:   Fri Apr 5 16:42:57 2024 -0700

    Use crtbeginT.o and crtend.o for non-PIE static executables
    
    When static PIE is enabled by default, we shouldn't use crtbeginS.o and
    crtendS.o for non-PIE static executables.  Check $($(@F)-no-pie) to use
    crtbeginT.o and crtend.o to create non-PIE static executables.
    Reviewed-by: Sunil K Pandey <skpgkp2@gmail.com>

Diff:
---
 Makeconfig | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)

diff --git a/Makeconfig b/Makeconfig
index 85e00cef94..e583765712 100644
--- a/Makeconfig
+++ b/Makeconfig
@@ -705,13 +705,15 @@ endif
 +prectorS = `$(CC) $(sysdep-LDFLAGS) --print-file-name=crtbeginS.o`
 +postctorS = `$(CC) $(sysdep-LDFLAGS) --print-file-name=crtendS.o`
 # Variants of the two previous definitions for statically linking programs.
+static-prector = `$(CC) $(sysdep-LDFLAGS) --print-file-name=crtbeginT.o`
+static-postctor = `$(CC) $(sysdep-LDFLAGS) --print-file-name=crtend.o`
 ifeq (yes,$(enable-static-pie))
 # Static PIE must use PIE variants.
-+prectorT = $(+prectorS)
-+postctorT = $(+postctorS)
++prectorT = $(if $($(@F)-no-pie),$(static-prector),$(+prectorS))
++postctorT = $(if $($(@F)-no-pie),$(static-postctor),$(+postctorS))
 else
-+prectorT = `$(CC) $(sysdep-LDFLAGS) --print-file-name=crtbeginT.o`
-+postctorT = `$(CC) $(sysdep-LDFLAGS) --print-file-name=crtend.o`
++prectorT = $(static-prector)
++postctorT =$(static-postctor)
 endif
 csu-objpfx = $(common-objpfx)csu/
 elf-objpfx = $(common-objpfx)elf/

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2024-04-08 16:26 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-04-08 16:26 [glibc] Use crtbeginT.o and crtend.o for non-PIE static executables H.J. Lu

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).