public inbox for gnats-cvs@sourceware.org
help / color / mirror / Atom feed
* gnats/gnats ChangeLog client.c cmds.c gnatsd.c ...
@ 1999-09-27 21:49 bmanson
0 siblings, 0 replies; only message in thread
From: bmanson @ 1999-09-27 21:49 UTC (permalink / raw)
To: gnats-cvs
CVSROOT: /cvs/gnats
Module name: gnats
Changes by: bmanson@egcs.cygnus.com 99/09/27 21:49:46
Modified files:
gnats : ChangeLog client.c cmds.c gnatsd.c pr.h query.c
query.h
Log message:
* pr.h (SearchType): Added DefaultSearchType value.
* query.c (add_query_builtin_field): New function.
Changed previous callers of add_query_field to use it as
appropriate.
(searchTypes): Added entry for DefaultSearchType.
(pr_match_field): Handle DefaultSearchType.
Boingy boingy boingy. Can you say "rubber ball on the end of a paddle?"
Comments from query.c:
I don't like having the builtin field stuff either. However, it
simplfies query-pr's job, because otherwise it would have to parse
arguments twice. The reason is that we don't know the indexes for
the builtin fields before we've read in and parsed the
configuration file, and we can't do that until after we've
processed our arguments to find out if we're a network client (and
the name of our server etc).
Instead, we refer to the builtin fields directly, and let
pr_match_field () take care of it later, after we've parsed the
config file.
We'll probably have to parse arguments twice eventually anyway, but
let's try to postpone it as long as possible. One sensible
alternative is to convert the old-style query options into a
new-style query expression, then parse that instead.
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~1999-09-27 21:49 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
1999-09-27 21:49 gnats/gnats ChangeLog client.c cmds.c gnatsd.c bmanson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).