* renaming the Originator field
@ 2003-10-06 22:56 Mel Hatzis
2003-10-12 12:39 ` Andrew J. Gray
2003-10-26 7:37 ` Andrew J. Gray
0 siblings, 2 replies; 3+ messages in thread
From: Mel Hatzis @ 2003-10-06 22:56 UTC (permalink / raw)
To: help-gnats
Please review the following patch which fixes a bug associated with
renaming the Originator field:
Index: file-pr.c
===================================================================
RCS file: /cvs/juniper/sw-tools/src/gnats-dbi-4.1/gnats/file-pr.c,v
retrieving revision 1.7
diff -b -u -p -r1.7 file-pr.c
--- file-pr.c 30 Sep 2003 01:35:49 -0000 1.7
+++ file-pr.c 6 Oct 2003 22:43:34 -0000
@@ -126,7 +126,7 @@ createNewPR (PR *pr, ErrorDesc *err)
/* If originator wasn't set, try to get the value from the From mail
header. This is what users usually expect. */
{
- FieldIndex idx_origin = find_field_index (database, "Originator");
+ FieldIndex idx_origin = ORIGINATOR (database);
const char *value_origin = (idx_origin == InvalidFieldIndex
? NULL
: field_value (pr, idx_origin));
If the Originator field is renamed, an attempt to create a new
PR results in gnatsd executing 'abort' inside set_field.
The fix is to use the "builtin" field name rather than the
field's external name.
--
Mel Hatzis
_______________________________________________
Help-gnats mailing list
Help-gnats@gnu.org
http://mail.gnu.org/mailman/listinfo/help-gnats
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: renaming the Originator field
2003-10-06 22:56 renaming the Originator field Mel Hatzis
@ 2003-10-12 12:39 ` Andrew J. Gray
2003-10-26 7:37 ` Andrew J. Gray
1 sibling, 0 replies; 3+ messages in thread
From: Andrew J. Gray @ 2003-10-12 12:39 UTC (permalink / raw)
To: hatzis; +Cc: help-gnats
Hi Mel,
> Please review the following patch which fixes a bug associated with
> renaming the Originator field:
Thanks for that patch, I will review it.
--
Andrew J. Gray
GNU GNATS Maintainer
_______________________________________________
Help-gnats mailing list
Help-gnats@gnu.org
http://mail.gnu.org/mailman/listinfo/help-gnats
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: renaming the Originator field
2003-10-06 22:56 renaming the Originator field Mel Hatzis
2003-10-12 12:39 ` Andrew J. Gray
@ 2003-10-26 7:37 ` Andrew J. Gray
1 sibling, 0 replies; 3+ messages in thread
From: Andrew J. Gray @ 2003-10-26 7:37 UTC (permalink / raw)
To: hatzis; +Cc: help-gnats
Hi Mel,
> Please review the following patch which fixes a bug associated with
> renaming the Originator field:
Thank you for submitting that fix. I have committed your fix, it will
be included in the next GNATS release.
--
Andrew J. Gray
GNU GNATS Maintainer
_______________________________________________
Help-gnats mailing list
Help-gnats@gnu.org
http://mail.gnu.org/mailman/listinfo/help-gnats
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2003-10-26 7:37 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2003-10-06 22:56 renaming the Originator field Mel Hatzis
2003-10-12 12:39 ` Andrew J. Gray
2003-10-26 7:37 ` Andrew J. Gray
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).