public inbox for gnats-devel@sourceware.org
 help / color / mirror / Atom feed
From: dirk bergstrom <dirk@juniper.net>
To: "Andrew J. Gray" <andrewg@gnu.org>
Cc: hatzis@juniper.net
Cc: help-gnats@gnu.org
Subject: Re: patch to display new PR number for new submissions
Date: Mon, 09 Dec 2002 10:54:00 -0000	[thread overview]
Message-ID: <3DF43E98.90104@juniper.net> (raw)
In-Reply-To: <200212080625.gB86Pvh07876@localhost.localdomain>

Andrew J. Gray expounded at length upon:
> I have a concern that the changes it makes to the gnatsd command
> protocol break the assumption that clients should not attempt to parse
> the message strings on response lines from the server
> I was thinking that it would be more consistent to have the server
> return:
> 351-The added PR number is:
> 350 68

hmmm.  very good point.  i think that's a heck of a lot easier to program
to.  if i may make a suggestion, it might be clearer as:

210-PR submission accepted.
351-The new PR was assigned number:
350 68

that way you get a clear 210 (OK) response, and the PR number as
additional information.

furthermore, if you're going to make the change to SUBM, i think it would
be good to consider the response to the CHDB command.  currently gnats
replies with the access level, but it must be parsed out of the string:

200 snowy.juniper.net GNATS server 4.0-beta2 ready.
chdb default dbergstr foo
210-Now accessing GNATS database 'default'
210 User access level set to 'edit'

this might be better as:

200 snowy.juniper.net GNATS server 4.0-beta2 ready.
chdb default dbergstr foo
210-Now accessing GNATS database:
350-default
351-User access level set to:
350 edit

or something like that...

i bring this up because i've just written a java gnats client, and had to
go out of my way to parse both replies...

-- 
Dirk Bergstrom               dirk@juniper.net
_____________________________________________
Juniper Networks Inc.,          Computer Geek
Tel: 408.745.3182           Fax: 408.745.8905



_______________________________________________
Help-gnats mailing list
Help-gnats@gnu.org
http://mail.gnu.org/mailman/listinfo/help-gnats

  parent reply	other threads:[~2002-12-09  7:11 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-12-02 15:08 GNU GNATS 4.0 beta2 released Andrew J. Gray
2002-12-02 15:11 ` compiling gnats 4.0 beta 2 Steve Friedman
2002-12-04  2:36   ` Andrew J. Gray
2002-12-03 19:52 ` patch to display new PR number for new submissions Mel Hatzis
2002-12-04  3:02   ` Andrew J. Gray
2002-12-08  7:58   ` Andrew J. Gray
2002-12-08 12:27     ` Yngve Svendsen
2002-12-08 23:11       ` Patching the manual Lars Henriksen
2002-12-12  3:58         ` Yngve Svendsen
2002-12-12  6:29       ` patch to display new PR number for new submissions Andrew J. Gray
2002-12-08 23:11     ` Mel Hatzis
2003-02-02  9:32       ` Andrew J. Gray
2003-02-03 20:46         ` Mel Hatzis
2003-02-03 20:51           ` Yngve Svendsen
2003-02-03 21:17             ` Mel Hatzis
2003-02-03 22:10               ` Yngve Svendsen
2003-02-09  8:28               ` Andrew J. Gray
2003-02-09  7:48           ` Andrew J. Gray
2003-04-29 20:24             ` Yngve Svendsen
2002-12-09 10:54     ` dirk bergstrom [this message]
2002-12-14 14:26       ` Andrew J. Gray
2003-08-30 11:58   ` Andrew J. Gray

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3DF43E98.90104@juniper.net \
    --to=dirk@juniper.net \
    --cc=andrewg@gnu.org \
    --cc=hatzis@juniper.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).