From: Mel Hatzis <hatzis@juniper.net>
To: "Andrew J. Gray" <andrewg@gnu.org>
Cc: help-gnats@gnu.org
Subject: Re: patch to display new PR number for new submissions
Date: Sun, 08 Dec 2002 23:11:00 -0000 [thread overview]
Message-ID: <3DF3A833.3060508@juniper.net> (raw)
In-Reply-To: <200212080625.gB86Pvh07876@localhost.localdomain>
On 12/07/2002 10:25 PM, Andrew J. Gray submitted:
>>Now that 4.0 beta2 is out the door please review
>>(and hopefully accept) the following patch which
>>allows send-pr and "pr-edit --submit" to display
>>newly created PR numbers.
>>
>>
>
>Thanks for submitting that patch, I have had a look at it.
>
>I have a concern that the changes it makes to the gnatsd command
>protocol break the assumption that clients should not attempt to parse
>the message strings on response lines from the server.
>
>As I understand it the current protocol for submitting PRs goes
>something like:
>
>-> SUBM
><- 211 Ok.
>-> <PR contents>
>-> <PR contents>
>-> .
><- 210 PR Added.
>
>(-> is from the client, <- is from the server)
>With your changes the response from the server would be, for example:
>
><- 210 PR 68 Added.
>
>I was thinking that it would be more consistent to have the server
>return:
>
><- 351-The added PR number is:
><- 350 68
>
>What do you think? Can you see problems with implementing the "return
>PR number to submitter" functionality in the way I am suggesting?
>
>
I see no problems with your suggested approach.
>I try to code modifications to your patch along these lines.
>
>
>
OK great....thanks for looking at the patch.
--
Mel Hatzis
_______________________________________________
Help-gnats mailing list
Help-gnats@gnu.org
http://mail.gnu.org/mailman/listinfo/help-gnats
next prev parent reply other threads:[~2002-12-08 20:27 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-12-02 15:08 GNU GNATS 4.0 beta2 released Andrew J. Gray
2002-12-02 15:11 ` compiling gnats 4.0 beta 2 Steve Friedman
2002-12-04 2:36 ` Andrew J. Gray
2002-12-03 19:52 ` patch to display new PR number for new submissions Mel Hatzis
2002-12-04 3:02 ` Andrew J. Gray
2002-12-08 7:58 ` Andrew J. Gray
2002-12-08 12:27 ` Yngve Svendsen
2002-12-08 23:11 ` Patching the manual Lars Henriksen
2002-12-12 3:58 ` Yngve Svendsen
2002-12-12 6:29 ` patch to display new PR number for new submissions Andrew J. Gray
2002-12-08 23:11 ` Mel Hatzis [this message]
2003-02-02 9:32 ` Andrew J. Gray
2003-02-03 20:46 ` Mel Hatzis
2003-02-03 20:51 ` Yngve Svendsen
2003-02-03 21:17 ` Mel Hatzis
2003-02-03 22:10 ` Yngve Svendsen
2003-02-09 8:28 ` Andrew J. Gray
2003-02-09 7:48 ` Andrew J. Gray
2003-04-29 20:24 ` Yngve Svendsen
2002-12-09 10:54 ` dirk bergstrom
2002-12-14 14:26 ` Andrew J. Gray
2003-08-30 11:58 ` Andrew J. Gray
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3DF3A833.3060508@juniper.net \
--to=hatzis@juniper.net \
--cc=andrewg@gnu.org \
--cc=help-gnats@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).