public inbox for gnats-devel@sourceware.org
 help / color / mirror / Atom feed
* bug setting EditUserEmailAddr for applyChangeActions
@ 2003-02-12  0:37 Mel Hatzis
  0 siblings, 0 replies; only message in thread
From: Mel Hatzis @ 2003-02-12  0:37 UTC (permalink / raw)
  To: help-gnats

EditUserEmailAddr is not getting set correctly for applyChangeActions.
Instead of picking up the email address of the user doing the edit,
the $EditUserEmailAddr named parameter is getting set to the value
of the 'From' field in the PR header.

Any change-actions associated with a PR update that make use of the
$EditUserEmailAddr named parameter are likely doing something
unexpected.

Please review the following patch...

Index: file-pr.c
===================================================================
RCS file: /cvsroot/gnats/gnats/gnats/file-pr.c,v
retrieving revision 1.51
diff -u -p -r1.51 file-pr.c
--- file-pr.c   1 Nov 2002 11:37:51 -0000       1.51
+++ file-pr.c   12 Feb 2003 00:28:58 -0000
@@ -845,7 +845,7 @@ Date: %s\n\
    else
      {
        if (edit_field (pr->database, number, AUDIT_TRAIL (pr->database), 1,
-                     xstrdup (buf), NULL, header_value (pr, FROM), err)
+                     xstrdup (buf), NULL, from, err)
           == 0)
         {
           return 1;

--
Mel Hatzis



_______________________________________________
Help-gnats mailing list
Help-gnats@gnu.org
http://mail.gnu.org/mailman/listinfo/help-gnats

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2003-02-12  0:37 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2003-02-12  0:37 bug setting EditUserEmailAddr for applyChangeActions Mel Hatzis

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).