public inbox for gnats-devel@sourceware.org
 help / color / mirror / Atom feed
From: Mel Hatzis <hatzis@juniper.net>
To: help-gnats@gnu.org
Subject: bug in edit-pr.sh - missing quote
Date: Tue, 18 Feb 2003 23:13:00 -0000	[thread overview]
Message-ID: <3E52BDBF.1000903@juniper.net> (raw)

Please review the following patch to edit-pr.sh which fixes
a bug in edit-pr which shows up when an edit is attempted on
a PR that has missing Enum fields.

The bug is caused by a missing single quote. It results
in displaying warnings prior to the invocation of the editor
as well as missing the Enum field descriptions in the edit
template (for the missing Enum fields), when it occurs.

--
Mel Hatzis

Index: edit-pr.sh
===================================================================
RCS file: /cvsroot/gnats/gnats/gnats/edit-pr.sh,v
retrieving revision 1.16
diff -b -u -p -r1.16 edit-pr.sh
--- edit-pr.sh  26 May 2002 15:32:02 -0000      1.16
+++ edit-pr.sh  18 Feb 2003 23:05:40 -0000
@@ -169,7 +169,7 @@ do
             type="`$QUERY_PR --field-type $field`"
             case $type in
                 [Ee][Nn][Uu][Mm])
-                   values=`$QUERY_PR --valid-values $field | tr '\n' ' ' | sed 's/ *$//g; s/ / | /g;s/^/[ /;s/$/ ]/;`
+                   values=`$QUERY_PR --valid-values $field | tr '\n' ' ' | sed 's/ *$//g; s/ / | /g;s/^/[ /;s/$/ ]/;'`
                     valslen=`echo "$values" | wc -c`
                     if [ "$valslen" -gt 160 ]
                     then



_______________________________________________
Help-gnats mailing list
Help-gnats@gnu.org
http://mail.gnu.org/mailman/listinfo/help-gnats

                 reply	other threads:[~2003-02-18 23:13 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3E52BDBF.1000903@juniper.net \
    --to=hatzis@juniper.net \
    --cc=help-gnats@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).