public inbox for gnats-devel@sourceware.org
 help / color / mirror / Atom feed
* bug in edit-pr.sh - missing quote
@ 2003-02-18 23:13 Mel Hatzis
  0 siblings, 0 replies; only message in thread
From: Mel Hatzis @ 2003-02-18 23:13 UTC (permalink / raw)
  To: help-gnats

Please review the following patch to edit-pr.sh which fixes
a bug in edit-pr which shows up when an edit is attempted on
a PR that has missing Enum fields.

The bug is caused by a missing single quote. It results
in displaying warnings prior to the invocation of the editor
as well as missing the Enum field descriptions in the edit
template (for the missing Enum fields), when it occurs.

--
Mel Hatzis

Index: edit-pr.sh
===================================================================
RCS file: /cvsroot/gnats/gnats/gnats/edit-pr.sh,v
retrieving revision 1.16
diff -b -u -p -r1.16 edit-pr.sh
--- edit-pr.sh  26 May 2002 15:32:02 -0000      1.16
+++ edit-pr.sh  18 Feb 2003 23:05:40 -0000
@@ -169,7 +169,7 @@ do
             type="`$QUERY_PR --field-type $field`"
             case $type in
                 [Ee][Nn][Uu][Mm])
-                   values=`$QUERY_PR --valid-values $field | tr '\n' ' ' | sed 's/ *$//g; s/ / | /g;s/^/[ /;s/$/ ]/;`
+                   values=`$QUERY_PR --valid-values $field | tr '\n' ' ' | sed 's/ *$//g; s/ / | /g;s/^/[ /;s/$/ ]/;'`
                     valslen=`echo "$values" | wc -c`
                     if [ "$valslen" -gt 160 ]
                     then



_______________________________________________
Help-gnats mailing list
Help-gnats@gnu.org
http://mail.gnu.org/mailman/listinfo/help-gnats

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2003-02-18 23:13 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2003-02-18 23:13 bug in edit-pr.sh - missing quote Mel Hatzis

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).