public inbox for gnats-devel@sourceware.org
 help / color / mirror / Atom feed
From: Mel Hatzis <hatzis@juniper.net>
To: help-gnats@gnu.org
Subject: memory leak in client code
Date: Mon, 12 May 2003 22:03:00 -0000	[thread overview]
Message-ID: <3EC01A06.8020809@juniper.net> (raw)

Please review the patch below which fixes a memory leak
with client reads from the server.

The memory leak generally results in 'unable to allocate memory'
(or 'unable to reallocate memory') errors particularly when
a 'query-pr --full' is attempted on a relatively large PR
database.

--
Mel Hatzis


Index: client.c
===================================================================
RCS file: /cvsroot/gnats/gnats/gnats/client.c,v
retrieving revision 1.46
diff -b -u -p -r1.46 client.c
--- client.c    25 Nov 2002 13:58:33 -0000      1.46
+++ client.c    12 May 2003 21:57:58 -0000
@@ -263,6 +263,7 @@ read_server (FILE *outfp)
             }
           fprintf (outfp, "%s", recvline + i);
         }
+      free (recvline);
      }
  }




_______________________________________________
Help-gnats mailing list
Help-gnats@gnu.org
http://mail.gnu.org/mailman/listinfo/help-gnats

             reply	other threads:[~2003-05-12 22:03 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-05-12 22:03 Mel Hatzis [this message]
2003-10-26 11:21 ` Andrew J. Gray

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3EC01A06.8020809@juniper.net \
    --to=hatzis@juniper.net \
    --cc=help-gnats@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).