public inbox for gnats-devel@sourceware.org
 help / color / mirror / Atom feed
* memory leak in client code
@ 2003-05-12 22:03 Mel Hatzis
  2003-10-26 11:21 ` Andrew J. Gray
  0 siblings, 1 reply; 2+ messages in thread
From: Mel Hatzis @ 2003-05-12 22:03 UTC (permalink / raw)
  To: help-gnats

Please review the patch below which fixes a memory leak
with client reads from the server.

The memory leak generally results in 'unable to allocate memory'
(or 'unable to reallocate memory') errors particularly when
a 'query-pr --full' is attempted on a relatively large PR
database.

--
Mel Hatzis


Index: client.c
===================================================================
RCS file: /cvsroot/gnats/gnats/gnats/client.c,v
retrieving revision 1.46
diff -b -u -p -r1.46 client.c
--- client.c    25 Nov 2002 13:58:33 -0000      1.46
+++ client.c    12 May 2003 21:57:58 -0000
@@ -263,6 +263,7 @@ read_server (FILE *outfp)
             }
           fprintf (outfp, "%s", recvline + i);
         }
+      free (recvline);
      }
  }




_______________________________________________
Help-gnats mailing list
Help-gnats@gnu.org
http://mail.gnu.org/mailman/listinfo/help-gnats

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: memory leak in client code
  2003-05-12 22:03 memory leak in client code Mel Hatzis
@ 2003-10-26 11:21 ` Andrew J. Gray
  0 siblings, 0 replies; 2+ messages in thread
From: Andrew J. Gray @ 2003-10-26 11:21 UTC (permalink / raw)
  To: hatzis; +Cc: help-gnats

Hi Mel,

> Please review the patch below which fixes a memory leak
> with client reads from the server.

Thanks for this fix.  I have committed it, it will be included in the
next GNATS release.

-- 
Andrew J. Gray
GNU GNATS Maintainer


_______________________________________________
Help-gnats mailing list
Help-gnats@gnu.org
http://mail.gnu.org/mailman/listinfo/help-gnats

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2003-10-26 11:21 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2003-05-12 22:03 memory leak in client code Mel Hatzis
2003-10-26 11:21 ` Andrew J. Gray

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).