public inbox for gnats-devel@sourceware.org
 help / color / mirror / Atom feed
From: Mel Hatzis <mel@wattes.org>
To: Chad Walstrom <chewie@wookimus.net>
Cc: help-gnats@gnu.org
Subject: Re: patch #2 - towards a generic backend datastore
Date: Thu, 21 Apr 2005 23:52:00 -0000	[thread overview]
Message-ID: <42683B4A.6090101@wattes.org> (raw)
In-Reply-To: <42645A54.5040007@wattes.org>

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

I have done some additional testing with my proposed patch and
everything appears to be in order.

*I plan on committing these changes to the mainline tomorrow.*

Note that there is a minor change introduced with this patch.
If the index is reloaded when gnatsd processes an 'rset'
command, gnatsd currently generates the following message:

     210 Reset state...reloaded the index.

After this patch is committed, the following message will
be issued (which is the same message that is generated
currently, whenever the index is not reloaded):

     210 Reset state.

This change is required in order to make the client/server
interaction datastore agnostic. Thankfully, the rset command
was the only one which referred to the index - and thus
needed to be modified.

- --
Mel Hatzis

Mel Hatzis wrote:
> Please review the attached patch which contains a number of
> modifications intended to restructure the code to support a
> generalized backend datastore.
> 
> This second patch is rather large - larger than I originally
> planned. I expect that all subsequent patches will be
> significantly smaller.
> 
> The primary goal in this patch was to completely isolate the
> index from the generic (i.e. non-datastore specific) GNATS
> functionality and introduce a flat-file datastore library with
> which all relevant binaries are linked. A small addition to
> configure was made to build the flat-file datastore library
> by default.
> 
> This is a significant leap forward in generalizing the backend
> datastore. The GNATS/datastore interface really starts to become
> more obvious with this patch.
> 
> I have attempted to adequately describe all changes in detail
> in the ChangeLog. Feel free to ask me to elaborate where
> necessary.
> 
> Once again, I've run these changes through my regression test
> suite and they appear to work well. Of course, I encourage
> more testing if people have the bandwidth.
> 
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.2 (Darwin)
Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org

iD8DBQFCaDtKNF74HmYqaSERAqqaAJ4sKH+JurajgHwaTh6rJQDHx7yOZgCglfKh
afJu2EuD78wcvn26kWb4hnA=
=xffG
-----END PGP SIGNATURE-----


_______________________________________________
Help-gnats mailing list
Help-gnats@gnu.org
http://lists.gnu.org/mailman/listinfo/help-gnats

  reply	other threads:[~2005-04-21 23:52 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-04-19  1:11 Mel Hatzis
2005-04-21 23:52 ` Mel Hatzis [this message]
2005-04-22 21:04   ` Chad Walstrom

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=42683B4A.6090101@wattes.org \
    --to=mel@wattes.org \
    --cc=chewie@wookimus.net \
    --cc=help-gnats@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).