Very small bug

Very small bug

[Dieperink Alwin]

Hi Yngve,

Here is a small correction for gnatsweb.pl. Without this, gnatsweb writes a
warning in the logfile.

Regards,
-- Alwin


1362c1362
<            && ($2 !=~ "compatible") )
---
>            && ($2 !~ "compatible") )


_______________________________________________
Help-gnats mailing list
Help-gnats@gnu.org
http://mail.gnu.org/mailman/listinfo/help-gnats

Re: Very small bug

[Yngve Svendsen]

At 19:35 06.01.2003 +0100, Dieperink Alwin wrote:
>Hi Yngve,
>
>Here is a small correction for gnatsweb.pl. Without this, gnatsweb writes a
>warning in the logfile.

Thanks. Committed.

- Yngve 



_______________________________________________
Help-gnats mailing list
Help-gnats@gnu.org
http://mail.gnu.org/mailman/listinfo/help-gnats

Re: Very small bug

[Lars Henriksen]

On Mon, Jan 06, 2003 at 07:35:03PM +0100, Dieperink Alwin wrote:
> Hi Yngve,
> 
> Here is a small correction for gnatsweb.pl. Without this, gnatsweb writes a
> warning in the logfile.
> 
> Regards,
> -- Alwin
> 
> 
> 1362c1362
> <            && ($2 !=~ "compatible") )
> ---
> >            && ($2 !~ "compatible") )

There's more. Opera (at least version 6.04) also doesn't like the double
encoding.

Lars Henriksen

diff -u -r1.120 gnatsweb.pl
--- gnatsweb.pl 8 Jan 2003 13:04:17 -0000       1.120
+++ gnatsweb.pl 8 Jan 2003 13:28:06 -0000
@@ -1357,9 +1357,10 @@
   my $body    = $q->escape(get_viewpr_url($pr));
 
   # Netscape Navigator up to and including 4.x should get the URL in
-  # the body encoded only once
-  unless ( ($ENV{'HTTP_USER_AGENT'} =~ "Mozilla\/(.)(.*)") && ($1 < 5)
-           && ($2 !~ "compatible") )
+  # the body encoded only once--and so should Opera.
+  unless (
+     ( $ENV{'HTTP_USER_AGENT'} =~ "Mozilla\/(.)(.*)" && $1 < 5 && $2 !~ "compatible" )
+    || $ENV{'HTTP_USER_AGENT'} =~ "Opera\/" )
   {
     $body = $q->escape($body);
   }


_______________________________________________
Help-gnats mailing list
Help-gnats@gnu.org
http://mail.gnu.org/mailman/listinfo/help-gnats

Re: Very small bug

[Yngve Svendsen]

At 14:31 08.01.2003 +0100, Lars Henriksen wrote:
>There's more. Opera (at least version 6.04) also doesn't like the double
>encoding.

Ouch. Mailto encoding is a well known troublemaker, and there seems to be 
an infinite number of combinations of mail clients and web browsers that 
all require different encodings. Anyone have any better ideas?

- Yngve 



_______________________________________________
Help-gnats mailing list
Help-gnats@gnu.org
http://mail.gnu.org/mailman/listinfo/help-gnats

Re: Very small bug

[Yngve Svendsen]

At 14:31 08.01.2003 +0100, Lars Henriksen wrote:
>On Mon, Jan 06, 2003 at 07:35:03PM +0100, Dieperink Alwin wrote:
> > Hi Yngve,
> >
> > Here is a small correction for gnatsweb.pl. Without this, gnatsweb writes a
> > warning in the logfile.
> >
> > Regards,
> > -- Alwin
> >
> >
> > 1362c1362
> > <            && ($2 !=~ "compatible") )
> > ---
> > >            && ($2 !~ "compatible") )
>
>There's more. Opera (at least version 6.04) also doesn't like the double
>encoding.

I committed the fix for Opera. "Advanced" mailto links are really a 
horrible mess since browsers decode them differently, and mail clients may 
also handle them in different ways.

- Yngve 



_______________________________________________
Help-gnats mailing list
Help-gnats@gnu.org
http://mail.gnu.org/mailman/listinfo/help-gnats