PATCH: v4 send-pr --request-id is broken

PATCH: v4 send-pr --request-id is broken

[Yngve Svendsen]

send-pr --request-id is not working in the current v4 CVS. Instead of the 
intended PR, the default template would be sent. The following patch fixes 
this.

Yngve Svendsen


Index: send-pr.sh
===================================================================
RCS file: /cvs/gnats/gnats/send-pr/send-pr.sh,v
retrieving revision 1.16
diff -u -p -r1.16 send-pr.sh
--- send-pr.sh	2001/04/08 18:28:25	1.16
+++ send-pr.sh	2001/05/15 14:29:29
@@ -432,16 +432,16 @@ fi
  # TEMP is the PR that we are editing.  When we're done, REF will contain
  # the final PR to be sent.

-while [ -z "$REQUEST_ID" ]; do
-  CNT=0
+#
+# Remove comments.
+#
+echo '/^SEND-PR:/d' >> $FIXFIL
+sed -f $FIXFIL $TEMP > $REF

-  #
-  #	Remove comments.
-  #
-  echo '/^SEND-PR:/d' >> $FIXFIL
-  sed -f $FIXFIL $TEMP > $REF
+# REF now has the actual PR that we want to send.

-  # REF now has the actual PR that we want to send.
+while [ -z "$REQUEST_ID" ]; do
+  CNT=0

    #
    # Check that synopsis is not empty.

Re: PATCH: v4 send-pr --request-id is broken

[Milan Zamazal]

>>>>> "YS" == Yngve Svendsen <yngve.svendsen@clustra.com> writes:

    YS> send-pr --request-id is not working in the current v4
    YS> CVS. Instead of the intended PR, the default template would be
    YS> sent. The following patch fixes this.

I don't understand the patch, could you elaborate, please?

    YS> Index: send-pr.sh
    YS> ===================================================================
    YS> RCS file: /cvs/gnats/gnats/send-pr/send-pr.sh,v
    YS> retrieving revision 1.16
    YS> diff -u -p -r1.16 send-pr.sh
    YS> --- send-pr.sh	2001/04/08 18:28:25	1.16
    YS> +++ send-pr.sh	2001/05/15 14:29:29
    YS> @@ -432,16 +432,16 @@ fi
    YS>   # TEMP is the PR that we are editing.  When we're done, REF will contain
    YS>   # the final PR to be sent.

    YS> -while [ -z "$REQUEST_ID" ]; do
    YS> -  CNT=0
    YS> +#
    YS> +# Remove comments.
    YS> +#
    YS> +echo '/^SEND-PR:/d' >> $FIXFIL
    YS> +sed -f $FIXFIL $TEMP > $REF

    YS> -  #
    YS> -  #	Remove comments.
    YS> -  #
    YS> -  echo '/^SEND-PR:/d' >> $FIXFIL
    YS> -  sed -f $FIXFIL $TEMP > $REF
    YS> +# REF now has the actual PR that we want to send.

    YS> -  # REF now has the actual PR that we want to send.
    YS> +while [ -z "$REQUEST_ID" ]; do
    YS> +  CNT=0

    YS>     #
    YS>     # Check that synopsis is not empty.

Regards,

Milan Zamazal

-- 
  _/_\_/_  o     _\_/_\_  o     _/_\_/_  o     _\_/_\_  o    BEWARE!
-<_|_|_|_><--  -<_|_|_|_><--  -<_|_|_|_><--  -<_|_|_|_><--   *Bugs* are
   / \ /   o      \ / \   o      / \ /   o      \ / \   o     approaching!