PR 375 - Point 1

PR 375 - Point 1

[Mark Kuchel]

In regards to PR 375, I will deal with each of the individual points in 
it seperately (i.e., each of the * points). Anything > is from the PR.

> * The login page makes no mention of needing to have cookies enabled;
 
The problem here under lynx is that it doesn't use javascript.  For
lynx and other browsers in that class, adding in a simple 
<noscript>...</noscript> section telling them that they need cookies 
turned on to work.  This also works for browsers such as netscape and 
mozilla when you turn javascript off in them.
 
 
> but without cookies enabled it just redirects to another login
> page (under Netscape) or goes to a "Redirecting" page which does     
> nothing (under lynx).
 
gnatsweb can't set any cookies so goes back to the login page.  If 
netscape (or for that matter, any browser) has cookies disabled, then 
it will go back to the login page. With the noscript patch mentioned 
above, it shouldn't matter whether or not the user's browser has 
javascript capabilities or not, they should get the message they need 
to use a browser that supports cookies.  The problem with lynx and the 
redirecting page is already fixed through an earlier patch of mine.  
But not the problem with lynx and cookies.  I am having problems 
getting lynx to work with cookies.
 
> The latter problem seems to be because it is trying to use
> an HTTP "Refresh" header, which is not mentioned in RFC 2616 (the 
> HTTP 1.1 spec)
 
Yes that is true, but then again neither are cookies and they are sent 
in the http headers, and the problem has been overcome.    

The patch was tested with netscape 4.75, mozilla M18, lynx 2.8.4 and 
konqueror from kdebase 2.0.6 from mandrake.  

Note it messes up the formatting of the table at the top, but I can't 
figure out why (it no longer likes the fonts, is that because of 
javascript being turned off, I don't know).

Mark

-- 
--------------------------------------------------------------------
| Mark Kuchel            |                                         |
| mark@kuchel.net        | www.kuchel.net                          |
| Phone: 03 9387 4668    | Mobile: 0438 650 150                    |
--------------------------------------------------------------------

Re: PR 375 - Point 1

[Gerald Pfeifer]

On Wed, 10 Jan 2001, Mark Kuchel wrote:
>> * The login page makes no mention of needing to have cookies enabled;
> The problem here under lynx is that it doesn't use javascript.  For
> lynx and other browsers in that class, adding in a simple
> <noscript>...</noscript> section telling them that they need cookies
> turned on to work.  This also works for browsers such as netscape and
> mozilla when you turn javascript off in them.
> [...]
> The patch was tested with netscape 4.75, mozilla M18, lynx 2.8.4 and
> konqueror from kdebase 2.0.6 from mandrake.

Thanks!

I had fixed this in a somewhat different way for the modified version we
used for gcc.gnu.org, but I agree that using <noscript> is a much better
idea, so I merged our two patches and installed the following into the
GNATS repository (and on gcc.gnu.org as well, so that we have more
extensive testing).

Sorry for the delay, but now I'm nearly done with the gnatsweb patch
backlog. Send more patches! :-)

Gerald


2001-02-03  Mark Kuchel <mark@kuchel.net>
            Gerald Pfeifer  <pfeifer@dbai.tuwien.ac.at>

	* gnatsweb.pl (login_page_javascript): Properly warn about cookies
	being required, both if Javascript is enabled and if it is disabled.

Index: gnatsweb.pl
===================================================================
RCS file: /cvs/gnats/gnats/contrib/gnatsweb/gnatsweb.pl,v
retrieving revision 2.21
diff -u -3 -p -r2.21 gnatsweb.pl
--- gnatsweb.pl	2001/01/22 15:29:03	2.21
+++ gnatsweb.pl	2001/02/03 12:41:53
@@ -2815,13 +2815,21 @@ val = getCookie("gnatsweb-test-cookie");
 delCookie("gnatsweb-test-cookie");
 if (val == null) {
     document.write("<h2>Warning: your browser is not accepting cookies</h2>"
-        + "Gnatsweb requires cookies to keep track of your login and other "
-        + "information.  Please enable cookies before pressing the "
-        + "<tt>login</tt> button.");
+        ."<p>Unfortunately, Gnatsweb requires cookies to keep track of your "
+        ."login and other information. "
+        ."Please enable cookies before logging in.</p>");
 }

 //-->
 </SCRIPT>
+<noscript>
+<p>(Due to the fact that your browser does not support Javascript,
+there is no way of telling whether it can accept cookies.)
+
+Unfortunately, Gnatsweb requires cookies to keep track of your"
+login and other information.
+Please enable cookies before logging in.</p>
+</noscript>
   };
 }