gnats/11: file-pr fails to separate email addresses to notify

gnats/11: file-pr fails to separate email addresses to notify

[girgen]

>Number:         11
>Category:       gnats
>Synopsis:       file-pr fails to separate email addresses to notify
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    unassigned
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Mon Oct 11 17:24:00 PDT 1999
>Closed-Date:
>Last-Modified:
>Originator:     Palle Girgensohn
>Release:        3.112.1
>Organization:
>Environment:
FreeBSD-RELEASE-3.0
>Description:
file-pr creates a list of email addresses to notify using
the Resent-CC mail header. There's a bug that makes it fail
separating the addresses with a comma. This can lead to a
new mail beeing sent to gnats-admin, which generates a new
report. This new mail is in turn generating a new report,
a we have an endless loop!

The try_append_notify function doesn't use the returned
char*, but uses its input argument.

>How-To-Repeat:
Here's what I had in my categories file:
test:*Test Category:girgen:girgen@e.kth.se

and submitters:
submitters:partitur:Partitur:none:24:gnats-admin:palle@partitur.se

and here's the mail header:

Resent-CC: gnats-adminpalle@partitur.segirgen@e.kth.se

I realize this code in file-pr is quite modified in the
current cvs-tree, but this patch should probably be used
until that code is in the 3.x branch.
>Fix:
--- file-pr.c~  Wed Sep 22 01:18:39 1999 
+++ file-pr.c   Tue Oct 12 01:42:21 1999 
@@ -708,7 +708,7 @@ 
   char *try = append_notify (string); 
   if (try != NULL) 
     { 
-      strcat (notify, string); 
+      strcat (notify, try); 
       xfree (try); 
     } 
 } 
>Release-Note:
>Audit-Trail:
>Unformatted: