From: Indu Bhagat <indu.bhagat@oracle.com>
To: Carlos O'Donell <carlos@redhat.com>,
Florian Weimer <fweimer@redhat.com>,
Mark Wielaard <mark@klomp.org>
Cc: gnu-gabi@sourceware.org
Subject: Re: [PATCH] Add PT_GNU_SFRAME segment
Date: Tue, 24 Jan 2023 13:52:31 -0800 [thread overview]
Message-ID: <a8c0a94b-ddb0-6a0b-886e-a7c21cd15777@oracle.com> (raw)
In-Reply-To: <7fe71de8-b31d-9c0a-52ef-840396b707a1@redhat.com>
On 1/24/23 06:57, Carlos O'Donell wrote:
> On 1/24/23 08:20, Florian Weimer via Gnu-gabi wrote:
>> * Mark Wielaard:
>>
>>> Hi Indu,
>>>
>>> On Mon, 2023-01-23 at 11:56 -0800, Indu Bhagat via Gnu-gabi wrote:
>>>> As I submit this patch, I am reminded of my ongoing unease with using the
>>>> keyword "unwind information" with SFrame format. SFrame format, is the Simple
>>>> Frame format, which represents the minimal necessary information for
>>>> backtracing:
>>>> - Canonical Frame Address (CFA)
>>>> - Frame Pointer (FP)
>>>> - Return Address (RA)
>>>> As such, one can argue that there is a clear distinction between "backtrace"
>>>> (=simple call trace) and "unwind"(=stack walk + recover state/regs).
>>>>
>>>> What do you think will the "correct" terminology here (if there is one) ?
>>>> Simple Frame format is for backtracing only, but calling it a "backtrace
>>>> format" also sounds off. May be "backtracing format" ? Simple Frame, SFrame,
>>>> backtracing format...
>>>>
>>>> Thoughts?
>>>
>>> What about calling it a "call trace"?
>>> Although technically it is a "return trace".
>>
>> “Stack trace” matches “SFrame”. That's Python, Java etc. terminology
>> and seems appropriate here, too.
>
> Agreed, good point. I'm fine with the use of the word "stack" in this context.
>
> I looked at Java's documentation and they use the term "stack trace":
> https://docs.oracle.com/en/java/javase/19/docs/specs/man/jstack.html
>
> Likewise for Python the term is "stack traces":
> https://docs.python.org/3/library/traceback.html?highlight=stack%20trace
>
> That confirms the common usage in Java and Python.
>
> That's enough for me to consider "stack traces" a good choice.
>
> Note Ruby still calls it a "backtrace" in the context of exceptions:
> https://docs.ruby-lang.org/en/master/Exception.html#method-i-backtrace
> but I'd argue "stack trace" is a better choice there too.
>
Thanks folks.
"stack trace" seems to fit well.
prev parent reply other threads:[~2023-01-24 21:53 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-23 19:56 Indu Bhagat
2023-01-24 11:13 ` Mark Wielaard
2023-01-24 13:10 ` Carlos O'Donell
2023-01-24 13:20 ` Florian Weimer
2023-01-24 14:57 ` Carlos O'Donell
2023-01-24 21:52 ` Indu Bhagat [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a8c0a94b-ddb0-6a0b-886e-a7c21cd15777@oracle.com \
--to=indu.bhagat@oracle.com \
--cc=carlos@redhat.com \
--cc=fweimer@redhat.com \
--cc=gnu-gabi@sourceware.org \
--cc=mark@klomp.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).