public inbox for gsl-discuss@sourceware.org
 help / color / mirror / Atom feed
From: Patrick Alken <patrick.alken@colorado.edu>
To: gsl-discuss@sourceware.org
Cc: Rhys Ulerich <rhys.ulerich@gmail.com>
Subject: Re: [Help-gsl] Submitted patch to add bspline derivative capabilities
Date: Mon, 08 Dec 2008 21:12:00 -0000	[thread overview]
Message-ID: <20081124175854.GA994@hippogriff.homeunix.org> (raw)
In-Reply-To: <m38wr9cey2.wl%bjg@network-theory.co.uk>

The new code looks clean and very well written. I made a test
program comparing the gsl_bspline_eval_deriv output directly
with PPPACK's bvalue() routine, which is an independent implementation
of bspline derivatives (gsl_bspline_eval_deriv is based on bsplvd()).

The results look fine.  I also ran it through valgrind with good
results. I think it can be put into the next release.

Patrick

On Mon, Nov 24, 2008 at 03:37:57PM +0000, Brian Gough wrote:
> At Wed, 19 Nov 2008 16:50:47 -0700,
> Patrick Alken wrote:
> > 
> > I'm moving this discussion to the gsl-discuss list. Good work!
> > This is something several people have been asking for and I haven't
> > had any time to work on.
> > 
> > I will take a look at the patch in the next few days.
> 
> Patrick, I'm happy for you to take the decision on this wrt the 1.12
> release.  The main thing we want to avoid at this stage is breaking
> the build in ways that we might not detect in our own testing.
> 
> -- 
> Brian Gough

  reply	other threads:[~2008-11-24 17:49 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <4a00655d0811191412t371982eev1bb77325719860f7@mail.gmail.com>
2008-11-19 23:42 ` Patrick Alken
2008-12-07 12:29   ` Brian Gough
2008-12-08 21:12     ` Patrick Alken [this message]
2008-12-08 21:43       ` Brian Gough
2008-12-09  9:15         ` Patrick Alken
     [not found]           ` <4a00655d0811291850u684d1cd8k2bab8c651045cb11@mail.gmail.com>
2008-12-09 22:58             ` Patrick Alken
2008-12-10 18:25           ` Brian Gough
2008-12-11 12:52             ` Patrick Alken
     [not found]               ` <4a00655d0812051440v46865adbsfcc10bb7dce28d98@mail.gmail.com>
2008-12-11 15:18                 ` Rhys Ulerich
2008-12-12 11:14                   ` Brian Gough
2008-12-12 12:19                     ` Rhys Ulerich
2008-12-12 17:20                       ` Brian Gough
2008-12-11 17:03               ` Brian Gough

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20081124175854.GA994@hippogriff.homeunix.org \
    --to=patrick.alken@colorado.edu \
    --cc=gsl-discuss@sourceware.org \
    --cc=rhys.ulerich@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).