From: Rhys Ulerich <rhys.ulerich@gmail.com>
To: Brian Gough <bjg@network-theory.co.uk>
Cc: gsl-discuss@sourceware.org
Subject: Re: [PATCH] Adding fixed-order Gauss-Legendre integration routines
Date: Wed, 24 Jun 2009 16:49:00 -0000 [thread overview]
Message-ID: <4a00655d0906240949h29df5535k327ccb03d8d76f12@mail.gmail.com> (raw)
In-Reply-To: <4a00655d0906230958s521f52a1k5bcc9959adc862d@mail.gmail.com>
In that patch I screwed up the order of the GSL_ERROR_NULL vs free
calls within gsl_integration_glfixed_table, e.g.
w = (double *) malloc(m * sizeof(double));
if (w == 0)
{
GSL_ERROR_NULL ("failed to allocate space for weights",
GSL_ENOMEM);
free(x);
}
should definitely have their order flipped. The problem appears once
again just below those lines.
- Rhys
On Tue, Jun 23, 2009 at 11:58 AM, Rhys Ulerich<rhys.ulerich@gmail.com> wrote:
>> Could you redo the patch without the whitespace changes to make it
>> easier to see the actual changes, thanks.
>
> Definitely (attached) Didn't know about that git format-patch
> argument until just now...
>
> - Rhys
>
next prev parent reply other threads:[~2009-06-24 16:49 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <4a00655d0906211327x742b7224of110fa0621fbbad9@mail.gmail.com>
2009-06-21 20:31 ` Rhys Ulerich
2009-06-22 14:00 ` Rhys Ulerich
2009-06-23 16:52 ` Brian Gough
2009-06-23 16:58 ` Rhys Ulerich
2009-06-24 16:49 ` Rhys Ulerich [this message]
2009-06-28 20:41 ` Brian Gough
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4a00655d0906240949h29df5535k327ccb03d8d76f12@mail.gmail.com \
--to=rhys.ulerich@gmail.com \
--cc=bjg@network-theory.co.uk \
--cc=gsl-discuss@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).