public inbox for gsl-discuss@sourceware.org
 help / color / mirror / Atom feed
* eigen/test.c typo
@ 2006-09-12 19:30 Patrick Alken
  2006-09-14 13:04 ` Brian Gough
  0 siblings, 1 reply; 2+ messages in thread
From: Patrick Alken @ 2006-09-12 19:30 UTC (permalink / raw)
  To: gsl-discuss

Hi,

  I believe there typos in eigen/test.c. On line 247 (in the function
test_eigen_symm()) it sorts the eigenvalues with VAL_DESC a second
time - I think this should be ABS_DESC instead. The same thing
occurs in test_eigen_herm().

Patrick Alken

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: eigen/test.c typo
  2006-09-12 19:30 eigen/test.c typo Patrick Alken
@ 2006-09-14 13:04 ` Brian Gough
  0 siblings, 0 replies; 2+ messages in thread
From: Brian Gough @ 2006-09-14 13:04 UTC (permalink / raw)
  To: Patrick Alken; +Cc: gsl-discuss

At Tue, 12 Sep 2006 13:30:41 -0600,
Patrick Alken wrote:
>   I believe there typos in eigen/test.c. On line 247 (in the function
> test_eigen_symm()) it sorts the eigenvalues with VAL_DESC a second
> time - I think this should be ABS_DESC instead. The same thing
> occurs in test_eigen_herm().

Thanks you're right, I will fix that.  I guess we also need to extend
the tests to have some negative eigenvalues so that they cover the
different cases.

-- 
Brian Gough

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2006-09-14 13:04 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2006-09-12 19:30 eigen/test.c typo Patrick Alken
2006-09-14 13:04 ` Brian Gough

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).