gdk-color-change params (was: Completed RGB functionality)

[Kevin Ryde <user42@zip.com.au>]

[-- Attachment #1: Type: text/plain, Size: 797 bytes --]

I wrote:
>
> Another thing field setters would do is mean that gdk-color-change can
> take the same parameters as the C gdk_color_change, ie. a GdkColor
> containing a pixel value.  Unnecessary variations between the C and
> Scheme functions are not good.

I propose to make this change,

        * gdk-1.2.defs (gdk_color_change): Remove separate pixel parameter,
        take scheme-level parameters the same as the C function.
        * gdk-support.c (gdk_color_change_interp): Remove.

Whether a GdkColor structure is a particularly good way to pass
pixel+r+g+b is a matter for debate, personally I think it's sensible
enough in the context of colormap tricks.  Either way if there's a
burning need for some other interface then it should be under a new
name to avoid any possible confusion.


[-- Attachment #2: gdk-1.2.defs.color-change.diff --]
[-- Type: text/plain, Size: 618 bytes --]

--- gdk-1.2.defs.~1.32.~	2003-06-15 09:28:33.000000000 +1000
+++ gdk-1.2.defs	2003-06-15 09:59:06.000000000 +1000
@@ -1413,14 +1413,9 @@
   (GdkColor (copy #f))
   ((string spec)))
 
-(define-func gdk_color_change_interp
+(define-func gdk_color_change
   bool
   ((GdkColormap colormap)
-   ; The cmap_index is not there in gdk_color_change; gdk_color_change
-   ; adopts the ugly XStoreColor hack that stores the index in the pixel
-   ; value of the color. We ignore the pixel value and devote a whole
-   ; parameter for the worthy cause.
-   (int cmap_index)
    (GdkColor color)))
 
 (define-func gdk_color_equal

[-- Attachment #3: gdk-support.c.color-change.diff --]
[-- Type: text/plain, Size: 493 bytes --]

--- gdk-support.c.~1.22.~	2003-06-15 09:31:25.000000000 +1000
+++ gdk-support.c	2003-06-15 10:01:46.000000000 +1000
@@ -1406,16 +1406,6 @@
   return gdk_color_black (colormap, &color) ? gdk_color_copy (&color) : NULL;
 }
 
-int
-gdk_color_change_interp (GdkColormap *colormap, gint cmap_index,
-			 GdkColor *color)
-{
-  GdkColor _color;
-  _color = *color;
-  _color.pixel = cmap_index;
-  return gdk_color_change (colormap, &_color);
-}
-
 guint
 gdk_color_hash_interp (GdkColor *color)
 {