gtk_main_iteration and friends return val

gtk_main_iteration and friends return val

[Kevin Ryde]

[-- Attachment #1: Type: text/plain, Size: 508 bytes --]

I'd like to propose

        * gtk-1.2.defs (gtk_main_iteration, gtk_main_iteration_do, gtk_true,
        gtk_false, gtk_events_pending): Make returns #t/#f.

Currently these return integers to scheme, but I think they're all
just TRUE or FALSE at the C level and might be better as #t/#f.

In gtk 1.2 the C return types are gint, but in 2.2 this seems to have
been corrected to gboolean.

Hopefully no-one has used gtk-events-pending thinking it was a count
of pending events or something, which it's not.


[-- Attachment #2: gtk-1.2.defs.bools.diff --]
[-- Type: text/plain, Size: 458 bytes --]

--- gtk-1.2.defs.~1.7.~	2003-01-23 07:16:45.000000000 +1000
+++ gtk-1.2.defs	2003-02-06 10:00:28.000000000 +1000
@@ -362,23 +362,23 @@
   ())
 
 (define-func gtk_main_iteration
-  int
+  bool
   ())
 
 (define-func gtk_main_iteration_do
-  int
+  bool
   ((bool val)))
 
 (define-func gtk_true
-  int
+  bool
   ())
 
 (define-func gtk_false
-  int
+  bool
   ())
 
 (define-func gtk_events_pending
-  int
+  bool
   ())
 
 (define-func gtk_timeout_add_full

Re: gtk_main_iteration and friends return val

[Daniel Skarda]

Hello,

>         * gtk-1.2.defs (gtk_main_iteration, gtk_main_iteration_do, gtk_true,
>         gtk_false, gtk_events_pending): Make returns #t/#f.

  Accepted. Patched. And if I do not forget to write "cvs commit" after "pon",
it is in CVS repository in a minute :-)

  I am sorry it took me so long to apply the patch. 

Best regards,
0.