[PATCH/libgui] Fix cygwin build woes

[PATCH/libgui] Fix cygwin build woes

[Keith Seitz]

[-- Attachment #1: Type: text/plain, Size: 892 bytes --]

Hi,

I've committed the attached patch which should fix any problems with 
building libgui on cygwin. At least, it builds on *my* cygwin box.

NOTE: Not tested (and probably won't work) with mingw!

Please let me know (via this list) if there are any problems.

Keith

ChangeLog
2008-08-02  Keith Seitz  <keiths@redhat.com>

         * tcl.m4: Remove. I changed my mind.
         * acinclude.m4: Include ../config/tcl.m4.
         (CY_AC_TCL_PRIVATE_HEADERS): New macro.
         (CY_AC_TK_PRIVATE_HEADERS): New macro.
         * configure.ac: When using in-tree tcl/tk, include
         Tcl's/Tk's platform directory.
         When using installed Tcl/Tk, use CY_AC_{TCL,TK}_PRIVATE_HEADERS
         to find the private header files.
         * aclocal.m4: Regenerated.
         * configure: Regenerated.
         * library/Makefile.in: Regenerated.
         * src/Makefile.in: Regenerated.

[-- Attachment #2: libgui-cygwin-update.patch --]
[-- Type: text/x-patch, Size: 2777 bytes --]

Index: acinclude.m4
===================================================================
RCS file: /cvs/src/src/libgui/acinclude.m4,v
retrieving revision 1.3
diff -u -p -r1.3 acinclude.m4
--- acinclude.m4	22 Jul 2008 20:11:35 -0000	1.3
+++ acinclude.m4	2 Aug 2008 23:32:51 -0000
@@ -1 +1,43 @@
-"sinclude(tcl.m4)"
+sinclude(../config/tcl.m4)
+
+dnl Find the location of the private Tcl headers
+dnl When Tcl is installed, this is TCL_INCLUDE_SPEC/tcl-private/generic
+dnl When Tcl is in the build tree, this is not needed.
+dnl
+dnl Note: you must use first use SC_LOAD_TCLCONFIG!
+AC_DEFUN([CY_AC_TCL_PRIVATE_HEADERS], [
+  AC_MSG_CHECKING([for Tcl private headers])
+  private_dir=""
+  dir=`echo ${TCL_INCLUDE_SPEC}/tcl-private/generic | sed -e s/-I//`
+  if test -f ${dir}/tclInt.h ; then
+    private_dir=${dir}
+  fi
+
+  if test x"${private_dir}" = x; then
+    AC_ERROR(could not find private Tcl headers)
+  else
+    TCL_PRIVATE_INCLUDE="-I${private_dir}"
+    AC_MSG_RESULT(${private_dir})
+  fi
+])
+
+dnl Find the location of the private Tk headers
+dnl When Tk is installed, this is TK_INCLUDE_SPEC/tk-private/generic
+dnl When Tk is in the build tree, this not needed.
+dnl
+dnl Note: you must first use SC_LOAD_TKCONFIG
+AC_DEFUN([CY_AC_TK_PRIVATE_HEADERS], [
+  AC_MSG_CHECKING([for Tk private headers])
+  private_dir=""
+  dir=`echo ${TK_INCLUDE_SPEC}/tk-private/generic | sed -e s/-I//`
+  if test -f ${dir}/tkInt.h; then
+    private_dir=${dir}
+  fi
+
+  if test x"${private_dir}" = x; then
+    AC_ERROR(could not find Tk private headers)
+  else
+    TK_PRIVATE_INCLUDE="-I${private_dir}"
+    AC_MSG_RESULT(${private_dir})
+  fi
+])
Index: configure.ac
===================================================================
RCS file: /cvs/src/src/libgui/configure.ac,v
retrieving revision 1.3
diff -u -p -r1.3 configure.ac
--- configure.ac	22 Jul 2008 20:11:35 -0000	1.3
+++ configure.ac	2 Aug 2008 23:32:51 -0000
@@ -92,15 +92,22 @@ cd ${here}
 
 if test "${TCL_SRC_DIR}" = "${topdir}/tcl"; then
   # Using in-tree Tcl/Tk
-  TCL_INCLUDES="-I${TCL_SRC_DIR}/generic"
+  case "${host}" in
+    *-*-cygwin*) platDir="win" ;;
+    *) platDir="unix" ;;
+  esac
+
+  TCL_INCLUDES="-I${TCL_SRC_DIR}/generic -I${TCL_SRC_DIR}/${platDir}"
   TCL_LIBRARY=${TCL_BUILD_LIB_SPEC}
-  TK_INCLUDES="-I${TK_SRC_DIR}/generic"
+  TK_INCLUDES="-I${TK_SRC_DIR}/generic -I${TK_SRC_DIR}/${platDir}"
   TK_LIBRARY=${TK_BUILD_LIB_SPEC}
 else
   # Using installed Tcl/Tk
-  TCL_INCLUDES=${TCL_INCLUDE_SPEC}
+  CY_AC_TCL_PRIVATE_HEADERS
+  CY_AC_TK_PRIVATE_HEADERS
+  TCL_INCLUDES="${TCL_INCLUDE_SPEC} ${TCL_PRIVATE_INCLUDE}"
   TCL_LIBRARY=${TCL_LIB_SPEC}
-  TK_INCLUDES=${TK_INCLUDE_SPEC}
+  TK_INCLUDES="${TK_INCLUDE_SPEC} ${TK_PRIVATE_INCLUDE}"
   TK_LIBRARY=${TK_LIB_SPEC}
 fi
 

Re: [PATCH/libgui] Fix cygwin build woes

[Christopher Faylor]

On Sat, Aug 02, 2008 at 04:35:18PM -0700, Keith Seitz wrote:
>I've committed the attached patch which should fix any problems with
>building libgui on cygwin.  At least, it builds on *my* cygwin box.
>
>NOTE: Not tested (and probably won't work) with mingw!
>
>Please let me know (via this list) if there are any problems.

So where does cygwin stand now, Keith?  Is it time to decouple insight
from the gdb release, make it a standalone release, and make it rely on
X?  Is there a version of tk out there which works with on native
windows?

cgf

Re: [PATCH/libgui] Fix cygwin build woes

[Keith Seitz]

Christopher Faylor wrote:

> So where does cygwin stand now, Keith?  Is it time to decouple insight
> from the gdb release, make it a standalone release, and make it rely on
> X?  Is there a version of tk out there which works with on native
> windows?

I don't really know where cygwin stands. Right now, the versions of Tcl, 
Tk, Itcl, and Itk that are in sourceware are really hybrid monsters. 
There is no active cygwin maintainer for Tcl. That means native binaries 
only (which can be downloaded from ActiveState). Or someone could build 
his own binaries, based on the work that's been done on sourceware.

Itcl and Itk were pretty trivial to do, but I'm sure Tcl and Tk would be 
a bit tougher. But I don't see why it could not be done.

I have no opinion on moving Insight to X on cygwin. Insight's only 
requirement is Tcl and Tk, and it doesn't care how it gets it. :-)

I'm only attempting to decouple insight from Tcl and friends. I've tried 
ripping insight out of gdb, but it is a major, major pain: GDB abandoned 
libgdb way too early to make this possible. So insight will stay where 
it is.

My play, actually, is to abandon insight altogether, but I don't know 
when. In light of that, this has been an effort to get rid of some of 
insight's worst baggage. Licensing issues have made it possible so that 
only a Red Hat employee can easily work on insight (or at least anything 
non-trivial). So insight sits stagnant. I think it is simply time to 
move on.

I am faced with three possible decisions:

1) Keep up with insight, fixing bugs, rewriting what I can here and 
there, i.e., maintain the status quo.

2) Redesign/rewrite insight (probably move away from Tcl, too)

3) Abandon insight and devote time and energy to another project.

I know what I would like to do, but it's a huge undertaking, and I am 
not entirely sure I am either up to the challenge or have the time to 
wait for sufficient community momentum. Or worse, I commit a boatload of 
time and there is never any momentum -- just this situation insight 
faces today.

Keith

Re: [PATCH/libgui] Fix cygwin build woes

[Christopher Faylor]

On Mon, Aug 04, 2008 at 09:12:13PM -0700, Keith Seitz wrote:
> Christopher Faylor wrote:
>>So where does cygwin stand now, Keith?  Is it time to decouple insight
>>from the gdb release, make it a standalone release, and make it rely on
>>X?  Is there a version of tk out there which works with on native
>>windows?
>
>I don't really know where cygwin stands.  Right now, the versions of
>Tcl, Tk, Itcl, and Itk that are in sourceware are really hybrid
>monsters.

Yep.  Understood.  I'm sort of tired of fielding questions about them
actually.

>There is no active cygwin maintainer for Tcl.  That means native
>binaries only (which can be downloaded from ActiveState).  Or someone
>could build his own binaries, based on the work that's been done on
>sourceware.
>
>Itcl and Itk were pretty trivial to do, but I'm sure Tcl and Tk would
>be a bit tougher.  But I don't see why it could not be done.
>
>I have no opinion on moving Insight to X on cygwin.  Insight's only
>requirement is Tcl and Tk, and it doesn't care how it gets it.  :-)

I asked in the cygwin list and most people claim to be reluctantly ok
with an X requirement.  I was counselled not to make raw gdb rely on X
however (well duh).

Apparently a lot of people are using it.  I was surprised to hear that.

>I'm only attempting to decouple insight from Tcl and friends.  I've
>tried ripping insight out of gdb, but it is a major, major pain: GDB
>abandoned libgdb way too early to make this possible.  So insight will
>stay where it is.
>
>My play, actually, is to abandon insight altogether, but I don't know
>when.  In light of that, this has been an effort to get rid of some of
>insight's worst baggage.  Licensing issues have made it possible so
>that only a Red Hat employee can easily work on insight (or at least
>anything non-trivial).  So insight sits stagnant.  I think it is simply
>time to move on.

Since Red Hat was willing to release insight to the FSF would they also be
willing to just relinquish ownership entirely?  Would that make working on
it easier?

>I am faced with three possible decisions:
>
>1) Keep up with insight, fixing bugs, rewriting what I can here and
>there, i.e., maintain the status quo.
>
>2) Redesign/rewrite insight (probably move away from Tcl, too)
>
>3) Abandon insight and devote time and energy to another project.

Cygwin needs an X maintainer.  :-)

>I know what I would like to do, but it's a huge undertaking, and I am
>not entirely sure I am either up to the challenge or have the time to
>wait for sufficient community momentum.  Or worse, I commit a boatload
>of time and there is never any momentum -- just this situation insight
>faces today.

I think if you committed the time people would notice and might even
pitch in.  Aren't there some companies still using insight?

Were you thinking about possibly using gdb/mi?

cgf

RE: [PATCH/libgui] Fix cygwin build woes

[Dave Korn]

Christopher Faylor wrote on 05 August 2008 16:01:

   [ snip ]

  Once I've got gcc4 and setup.exe under control, I'll volunteer some time
and attention toward helping with insight.

  I really quite like the look-and-feel of the current insight, and the
independence from X, and I'd be willing to take a look at the tk/tcl/etc
"hybrid monsters" with a view to modernising them (refresh relative to
upstream sources) and making them build and run good for both cygwin and
mingw on windows, if that turns out to be possible.


    cheers,
      DaveK
-- 
Can't think of a witty .sigline today....

RE: [PATCH/libgui] Fix cygwin build woes

[Weddington, Eric]

 

> -----Original Message-----
> From: insight-owner@sourceware.org 
> [mailto:insight-owner@sourceware.org] On Behalf Of Dave Korn
> Sent: Tuesday, August 05, 2008 11:05 AM
> To: 'Keith Seitz'; 'insight'
> Subject: RE: [PATCH/libgui] Fix cygwin build woes
> 
>   Once I've got gcc4 and setup.exe under control, I'll 
> volunteer some time
> and attention toward helping with insight.
> 
>   I really quite like the look-and-feel of the current 
> insight, and the
> independence from X, and I'd be willing to take a look at the 
> tk/tcl/etc
> "hybrid monsters" with a view to modernising them (refresh relative to
> upstream sources) and making them build and run good for both 
> cygwin and
> mingw on windows, if that turns out to be possible.

You already have my thanks! :-)

RE: [PATCH/libgui] Fix cygwin build woes

[Dave Korn]

Weddington, Eric wrote on 05 August 2008 18:24:

>> -----Original Message-----
>> From: insight-owner On Behalf Of Dave Korn

>>   Once I've got gcc4 and setup.exe under control, I'll
>> volunteer some time
>> and attention toward helping with insight.

> 
> You already have my thanks! :-)


  Nooooooooooooo!  Don't thank me now or there goes all my incentive!  Wait
until I've got it underway at least!

;-)


    cheers,
      DaveK
-- 
Can't think of a witty .sigline today....

RE: [PATCH/libgui] Fix cygwin build woes

[Weddington, Eric]

 

> -----Original Message-----
> From: Dave Korn [mailto:dave.korn@artimi.com] 
> Sent: Tuesday, August 05, 2008 11:55 AM
> To: Weddington, Eric; 'Keith Seitz'; 'insight'
> Subject: RE: [PATCH/libgui] Fix cygwin build woes
> 
> Weddington, Eric wrote on 05 August 2008 18:24:
> 
> >> -----Original Message-----
> >> From: insight-owner On Behalf Of Dave Korn
> 
> >>   Once I've got gcc4 and setup.exe under control, I'll
> >> volunteer some time
> >> and attention toward helping with insight.
> 
> > 
> > You already have my thanks! :-)
> 
> 
>   Nooooooooooooo!  Don't thank me now or there goes all my 
> incentive!  Wait
> until I've got it underway at least!

Ok! Then I'll resort to begging:
Please, please, puh-leeaassee, if you could spare one teeny, tiny moment of your spare time?... :-D

[OT] RE: [PATCH/libgui] Fix cygwin build woes

[Dave Korn]

Weddington, Eric wrote on 05 August 2008 18:58:

>> -----Original Message-----
>> From: Dave Korn 
>> Sent: Tuesday, August 05, 2008 11:55 AM

>> Weddington, Eric wrote on 05 August 2008 18:24:
>> 
>>>> -----Original Message-----
>>>> From: insight-owner On Behalf Of Dave Korn
>> 
>>>>   Once I've got gcc4 and setup.exe under control, I'll volunteer some
>>>> time and attention toward helping with insight.
>> 
>>> 
>>> You already have my thanks! :-)
>> 
>> 
>>   Nooooooooooooo!  Don't thank me now or there goes all my incentive! 
>> Wait until I've got it underway at least!
> 
> Ok! Then I'll resort to begging:
> Please, please, puh-leeaassee, if you could spare one teeny, tiny moment
> of your spare time?... :-D 

  Nooooooooo!  That'll just bring reverse psychology into play and I'll feel
like I'm being nagged and start to get all resentful and defensive and not
want to do it!

  Probably your best strategy is to say nothing about it at all until I've
completely forgotten about the whole thing, then jump out from behind a bush
screaming incoherently while belabouring me about the head with a hippo.

  Although I can't be 100% sure that will work, I feel it has the best
chance of success!  :-D

[ We should TITTTL if this is going to go on much longer <g> ]

    cheers,
      DaveK
-- 
Can't think of a witty .sigline today....

Re: [PATCH/libgui] Fix cygwin build woes

[Christopher Faylor]

On Tue, Aug 05, 2008 at 06:04:32PM +0100, Dave Korn wrote:
>Christopher Faylor wrote on 05 August 2008 16:01:
>
>   [ snip ]
>
>  Once I've got gcc4 and setup.exe under control, I'll volunteer some time
>and attention toward helping with insight.
>
>  I really quite like the look-and-feel of the current insight, and the
>independence from X, and I'd be willing to take a look at the tk/tcl/etc
>"hybrid monsters" with a view to modernising them (refresh relative to
>upstream sources) and making them build and run good for both cygwin and
>mingw on windows, if that turns out to be possible.

I see that you've volunteered to help out with insight.  Can you tell me
when the next release will be?  I have some unspecified vague bugs that
may or may not be my fault and I was hoping that you will have
automatically fixed them when you make your new release.

Incidentally, I'd suggest rewriting insight in Ada.  I think you'll
definitely have fewer problems going forward that way.

HTH,
cgf

RE: [PATCH/libgui] Fix cygwin build woes

[Dave Korn]

Christopher Faylor wrote on 05 August 2008 21:52:

> On Tue, Aug 05, 2008 at 06:04:32PM +0100, Dave Korn wrote:
>> Christopher Faylor wrote on 05 August 2008 16:01:
>> 
>>   [ snip ]
>> 
>>  Once I've got gcc4 and setup.exe under control, I'll volunteer some time
>> and attention toward helping with insight.
>> 
>>  I really quite like the look-and-feel of the current insight, and the
>> independence from X, and I'd be willing to take a look at the tk/tcl/etc
>> "hybrid monsters" with a view to modernising them (refresh relative to
>> upstream sources) and making them build and run good for both cygwin and
>> mingw on windows, if that turns out to be possible.
> 
> I see that you've volunteered to help out with insight.

  What are ya, Clippy now?

<g>


    cheers,
      DaveK
-- 
Can't think of a witty .sigline today....