public inbox for insight@sourceware.org
 help / color / mirror / Atom feed
From: "Pierre Muller" <pierre.muller@ics-cnrs.unistra.fr>
To: "'Keith Seitz'" <keiths@redhat.com>,
	       "'Roland Schwingel'" <roland@onevision.com>
Cc: <insight@sourceware.org>
Subject: RE: [PATCH] Add missing prototype in gdbtk.c
Date: Fri, 30 Mar 2012 13:03:00 -0000	[thread overview]
Message-ID: <000701cd0e75$5e028b80$1a07a280$@muller@ics-cnrs.unistra.fr> (raw)
In-Reply-To: <4F74E9F1.20804@redhat.com>

In fact, the same error also appears when 
trying to compile a mingw32 version.

I hope that I found the reason:
Prototypes apparently require (void) instead of ().

The following patch fixes the problem for mingw32,

Is this patch OK?


Pierre Muller
GDB pascal language maintainer



2012-03-30  Pierre Muller  <muller@ics.u-strasbg.fr>

        * generic/gdbtk.h (close_bfds): Fox prototype.

Index: generic/gdbtk.h
===================================================================
RCS file: /cvs/src/src/gdb/gdbtk/generic/gdbtk.h,v
retrieving revision 1.13
diff -u -p -r1.13 gdbtk.h
--- generic/gdbtk.h     2 Sep 2008 17:29:23 -0000       1.13
+++ generic/gdbtk.h     30 Mar 2012 12:53:48 -0000
@@ -165,7 +165,7 @@ extern int gdbtk_disable_fputs;
 extern ptid_t gdbtk_get_ptid (void);

 #ifdef _WIN32
-extern void close_bfds ();
+extern void close_bfds (void);
 #endif /* _WIN32 */

 extern void


  reply	other threads:[~2012-03-30 13:03 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-19 12:10 Roland Schwingel
2012-03-29 23:02 ` Keith Seitz
2012-03-30 13:03   ` Pierre Muller [this message]
2012-03-30 13:10     ` Keith Seitz
2012-03-30 13:32       ` Pierre Muller
2012-03-30 13:36 Roland Schwingel
2012-03-30 13:48 Roland Schwingel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='000701cd0e75$5e028b80$1a07a280$@muller@ics-cnrs.unistra.fr' \
    --to=pierre.muller@ics-cnrs.unistra.fr \
    --cc=insight@sourceware.org \
    --cc=keiths@redhat.com \
    --cc=roland@onevision.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).