From: Keith Seitz <keiths@redhat.com>
To: Roland Schwingel <roland@onevision.com>
Cc: insight@sourceware.org
Subject: Re: [PATCH] Add missing prototype in gdbtk.c
Date: Thu, 29 Mar 2012 23:02:00 -0000 [thread overview]
Message-ID: <4F74E9F1.20804@redhat.com> (raw)
In-Reply-To: <4F67221F.2020906@onevision.com>
On 03/19/2012 05:10 AM, Roland Schwingel wrote:
> Changelog:
>
> 2012-03-19 Roland Schwingel <roland.schwingel@onevision.com>
>
> * generic/gdbtk.c: Add prototype for close_bfds().
>
> Any comments? Is this ok?
Hmm. There already appears to be a declaration for this in gdbtk.h:
#ifdef _WIN32
extern void close_bfds ();
#endif /* _WIN32 */
Perhaps that check needs updating to "#if defined(_WIN32) ||
defined(_WIN64)"?
[Consider that change pre-approved with updated ChangeLog entry.]
Keith
next prev parent reply other threads:[~2012-03-29 23:02 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-19 12:10 Roland Schwingel
2012-03-29 23:02 ` Keith Seitz [this message]
2012-03-30 13:03 ` Pierre Muller
2012-03-30 13:10 ` Keith Seitz
2012-03-30 13:32 ` Pierre Muller
2012-03-30 13:36 Roland Schwingel
2012-03-30 13:48 Roland Schwingel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F74E9F1.20804@redhat.com \
--to=keiths@redhat.com \
--cc=insight@sourceware.org \
--cc=roland@onevision.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).