public inbox for insight@sourceware.org
 help / color / mirror / Atom feed
* Patch for error when double-clicking on process in attach dialog
@ 2000-03-01 17:45 James Ingham
  0 siblings, 0 replies; only message in thread
From: James Ingham @ 2000-03-01 17:45 UTC (permalink / raw)
  To: insight

Hi, all...

I just checked in the following patch that fixes an error which would
arise if you double-clicked on a process in the Attach dialog if you
had not previously loaded the executable for the process.

Jim

Index: gdbtk/library/ChangeLog
===================================================================
RCS file: /cvs/src/src/gdb/gdbtk/library/ChangeLog,v
retrieving revision 1.2
diff -p -r1.2 ChangeLog
*** ChangeLog   2000/02/24 03:12:58     1.2
--- ChangeLog   2000/03/02 01:41:29
***************
*** 1,3 ****
--- 1,9 ----
+ 2000-03-01  James Ingham  <jingham@leda.cygnus.com>
+ 
+       * interface.tcl (_open_file): The window which had the focus could 
+       get deleted by the vwait implicit in the tk_getOpenFile call.  So
+       check and make sure it is still around before raising it...
+ 
  2000-02-23  Keith R Seitz  <kseitz@nwlink.com>
  
          * srctextwin.ith (_highlightAsmLine): Define new method.
Index: gdbtk/library/interface.tcl
===================================================================
RCS file: /cvs/src/src/gdb/gdbtk/library/interface.tcl,v
retrieving revision 1.1.1.1
diff -p -r1.1.1.1 interface.tcl
*** interface.tcl       2000/02/07 00:19:42     1.1.1.1
--- interface.tcl       2000/03/02 01:41:29
*************** proc _open_file {{file ""}} {
*** 776,784 ****
      ide_grab_support enable_all
      
      # If no one had the focus before, leave it that way (since I
!     # am not sure how this could happen...
      
!     if {$curFocus != ""} {
        raise [winfo toplevel $curFocus]
        focus $curFocus
      }
--- 776,786 ----
      ide_grab_support enable_all
      
      # If no one had the focus before, leave it that way (since I
!     # am not sure how this could happen...  Also, the vwait in 
!     # tk_getOpenFile could have allowed the curFocus window to actually
!     # be destroyed, so make sure it is still around.
      
!     if {$curFocus != "" && [winfo exists $curFocus]} {
        raise [winfo toplevel $curFocus]
        focus $curFocus
      }

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2000-03-01 17:45 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2000-03-01 17:45 Patch for error when double-clicking on process in attach dialog James Ingham

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).