* [RFA] Move include of regcache.h
@ 2001-07-31 10:13 Elena Zannoni
2001-07-31 10:21 ` Keith Seitz
0 siblings, 1 reply; 3+ messages in thread
From: Elena Zannoni @ 2001-07-31 10:13 UTC (permalink / raw)
To: insight
If one builds with -Werror, gdbtk-register.c doesn't build because it
calls register_read, and regcache.h is not included. I believe this
was a fallout of moving those functions to their own file, from
gdbtk-cmds.c.
OK to commit?
Elena
2001-07-31 Elena Zannoni <ezannoni@redhat.com>
* generic/gdbtk-cmds.c: Don't include regcache.h.
* generic/gdbtk-register.c: Include regcache.h.
Index: gdbtk-cmds.c
===================================================================
RCS file: /cvs/src/src/gdb/gdbtk/generic/gdbtk-cmds.c,v
retrieving revision 1.36
diff -u -p -r1.36 gdbtk-cmds.c
--- gdbtk-cmds.c 2001/05/25 21:06:18 1.36
+++ gdbtk-cmds.c 2001/07/31 17:10:11
@@ -34,7 +34,6 @@
#include "target.h"
#include "gdbcore.h"
#include "demangle.h"
-#include "regcache.h"
#include "linespec.h"
#include "tui/tui-file.h"
Index: gdbtk-register.c
===================================================================
RCS file: /cvs/src/src/gdb/gdbtk/generic/gdbtk-register.c,v
retrieving revision 1.2
diff -u -p -r1.2 gdbtk-register.c
--- gdbtk-register.c 2001/07/20 22:19:50 1.2
+++ gdbtk-register.c 2001/07/31 17:10:11
@@ -20,6 +20,7 @@
#include "defs.h"
#include "frame.h"
+#include "regcache.h"
#include "value.h"
#include <tcl.h>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [RFA] Move include of regcache.h
2001-07-31 10:13 [RFA] Move include of regcache.h Elena Zannoni
@ 2001-07-31 10:21 ` Keith Seitz
2001-07-31 10:35 ` Elena Zannoni
0 siblings, 1 reply; 3+ messages in thread
From: Keith Seitz @ 2001-07-31 10:21 UTC (permalink / raw)
To: Elena Zannoni; +Cc: insight
On Tue, 31 Jul 2001, Elena Zannoni wrote:
>
> If one builds with -Werror, gdbtk-register.c doesn't build because it
> calls register_read, and regcache.h is not included. I believe this
> was a fallout of moving those functions to their own file, from
> gdbtk-cmds.c.
>
> OK to commit?
Please do.
Thanks!
Keith
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [RFA] Move include of regcache.h
2001-07-31 10:21 ` Keith Seitz
@ 2001-07-31 10:35 ` Elena Zannoni
0 siblings, 0 replies; 3+ messages in thread
From: Elena Zannoni @ 2001-07-31 10:35 UTC (permalink / raw)
To: Keith Seitz; +Cc: Elena Zannoni, insight
Keith Seitz writes:
> On Tue, 31 Jul 2001, Elena Zannoni wrote:
>
> >
> > If one builds with -Werror, gdbtk-register.c doesn't build because it
> > calls register_read, and regcache.h is not included. I believe this
> > was a fallout of moving those functions to their own file, from
> > gdbtk-cmds.c.
> >
> > OK to commit?
>
> Please do.
>
> Thanks!
> Keith
>
Thanks.
It's in.
Elena
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2001-07-31 10:35 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2001-07-31 10:13 [RFA] Move include of regcache.h Elena Zannoni
2001-07-31 10:21 ` Keith Seitz
2001-07-31 10:35 ` Elena Zannoni
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).