moving GDB_TK setting into configure.in [FIXME]

moving GDB_TK setting into configure.in [FIXME]

[Phil Edwards]

The toplevel configure has some 'FIXME' notes about code that should
be moved from configure to configure.in.  This patch would do that.
The DJGPP-related bits have already been tested and approved (a few months
ago by Eli), but I wanted to hear a yes/no on the GDB_TK part.

I tried this back in January, but got bogged down in more important things.
The 'FIXME's keep nagging at me, though.  :-)

Phil


Index: configure
===================================================================
RCS file: /home/pme/Repositories/GCC/gcc/configure,v
retrieving revision 1.36
diff -u -3 -p -r1.36 configure
--- configure	2001/05/23 17:24:49	1.36
+++ configure	2001/05/24 09:00:01
@@ -1070,21 +1070,6 @@ export CXX
 export CFLAGS
 export CXXFLAGS
 
-# FIXME: This should be in configure.in, not configure
-case "$host" in
-	*go32*)
-	    enable_gdbtk=no ;;
-	*msdosdjgpp*)
-	    enable_gdbtk=no ;;
-esac
-
-# FIXME: This should be in configure.in, not configure
-# Determine whether gdb needs tk/tcl or not.
-if [ "$enable_gdbtk" != "no" ]; then
-	GDB_TK="all-tcl all-tk all-itcl all-tix all-libgui"
-else
-	GDB_TK=""
-fi
 
 for subdir in . ${subdirs} ; do
 
Index: configure.in
===================================================================
RCS file: /home/pme/Repositories/GCC/gcc/configure.in,v
retrieving revision 1.106
diff -u -3 -p -r1.106 configure.in
--- configure.in	2001/06/01 09:14:43	1.106
+++ configure.in	2001/06/01 21:12:19
@@ -270,6 +270,14 @@ if [ -z "${CC}" ] && [ "${build}" = "${h
   fi
 fi
 
+# These hosts cannot build this software.
+case "$host" in
+  *go32*)
+    enable_gdbtk=no ;;
+  *msdosdjgpp*)
+    enable_gdbtk=no ;;
+esac
+
 # We default to --with-shared on platforms where -fpic is meaningless.
 # Well, we don't yet, but we will.
 if false && [ "${host}" = "${target}" ] && [ x${enable_shared} = x ]; then
@@ -1013,6 +1021,14 @@ if [ x$with_gnu_as = xno ]; then
   use_gnu_as=no
   noconfigdirs="$noconfigdirs gas"
 fi
+
+# Determine whether gdb needs tk/tcl or not.
+if [ "$enable_gdbtk" != "no" ]; then
+  GDB_TK="all-tcl all-tk all-itcl all-tix all-libgui"
+else
+  GDB_TK=""
+fi
+
 
 # Figure out what language subdirectories are present.
 # Look if the user specified --enable-languages="..."; if not, use

Re: moving GDB_TK setting into configure.in [FIXME]

[Keith Seitz]

On Wed, 27 Jun 2001, Phil Edwards wrote:

> The toplevel configure has some 'FIXME' notes about code that should
> be moved from configure to configure.in.  This patch would do that.
> The DJGPP-related bits have already been tested and approved (a few months
> ago by Eli), but I wanted to hear a yes/no on the GDB_TK part.

Seems harmless enough. I don't know what else to say, other than, 'why
didn't it get put into configure.in to begin with?'

Keith

Re: moving GDB_TK setting into configure.in [FIXME]

[Phil Edwards]

On Wed, Jun 27, 2001 at 03:10:53PM -0700, Keith Seitz wrote:
> Seems harmless enough. I don't know what else to say, other than, 'why
> didn't it get put into configure.in to begin with?'

All before my time...  It bothers me, though; this seems deceptively simple
and way too easy.  :-)


Phil

-- 
Would I had phrases that are not known, utterances that are strange, in
new language that has not been used, free from repetition, not an utterance
which has grown stale, which men of old have spoken.
                                     - anonymous Egyptian scribe, c.1700 BC