From: "Martin M. Hunt" <hunt@redhat.com>
To: Andrew Cagney <ac131313@cygnus.com>, insight@sources.redhat.com
Subject: Re: [patch] Missing newline
Date: Fri, 05 Oct 2001 17:41:00 -0000 [thread overview]
Message-ID: <200111302335.PAA01234@cygnus.com> (raw)
In-Reply-To: <3C0810D4.2030807@cygnus.com>
On Friday 30 November 2001 03:05 pm, Andrew Cagney wrote:
> FYI,
>
> I checked in the attached as obvious.
>
> enjoy,
> Andrew
What isn't obvious is how I checked in that last function accidently.
I am removing the unapproved and unused function.
2001-11-30 Martin M. Hunt <hunt@redhat.com>
* library/interface.tcl (gdbtk_eval): Remove
undocumented debug function.
Index: library/interface.tcl
===================================================================
RCS file: /cvs/src/src/gdb/gdbtk/library/interface.tcl,v
retrieving revision 1.33
retrieving revision 1.34
diff -u -p -r1.33 -r1.34
--- interface.tcl 2001/11/22 00:26:12 1.33
+++ interface.tcl 2001/11/30 23:31:15 1.34
@@ -1767,21 +1767,3 @@ proc gdbtk_tcl_architecture_changed {} {
GDBEventHandler::dispatch $e
delete object $e
}
-
-proc gdbtk_eval {exp} {
- debug $exp
- set ret [catch {gdb_cmd "p/x $exp"} val]
- if {$ret} {
- return ""
- }
-
- debug "val=\"$val\""
- # response looks like "$1 = value\n"
- set ind [string first "=" $val]
- if { $ind == -1 } { return "" }
- set val [string range $val [expr $ind + 1] [string length $val]]
- set val [string trimleft $val]
- set val [string trimright $val "\n"]
- debug "returning \"$val\""
- return $val
-}
\ No newline at end of file
--
Martin Hunt
GDB Engineer
Red Hat, Inc.
WARNING: multiple messages have this Message-ID
From: "Martin M. Hunt" <hunt@redhat.com>
To: Andrew Cagney <ac131313@cygnus.com>, insight@sources.redhat.com
Subject: Re: [patch] Missing newline
Date: Fri, 30 Nov 2001 15:36:00 -0000 [thread overview]
Message-ID: <200111302335.PAA01234@cygnus.com> (raw)
Message-ID: <20011130153600.16qhWN3MYo_HV8PNggxQaJCLzT0P5oB9kxxrxinw_yg@z> (raw)
In-Reply-To: <3C0810D4.2030807@cygnus.com>
On Friday 30 November 2001 03:05 pm, Andrew Cagney wrote:
> FYI,
>
> I checked in the attached as obvious.
>
> enjoy,
> Andrew
What isn't obvious is how I checked in that last function accidently.
I am removing the unapproved and unused function.
2001-11-30 Martin M. Hunt <hunt@redhat.com>
* library/interface.tcl (gdbtk_eval): Remove
undocumented debug function.
Index: library/interface.tcl
===================================================================
RCS file: /cvs/src/src/gdb/gdbtk/library/interface.tcl,v
retrieving revision 1.33
retrieving revision 1.34
diff -u -p -r1.33 -r1.34
--- interface.tcl 2001/11/22 00:26:12 1.33
+++ interface.tcl 2001/11/30 23:31:15 1.34
@@ -1767,21 +1767,3 @@ proc gdbtk_tcl_architecture_changed {} {
GDBEventHandler::dispatch $e
delete object $e
}
-
-proc gdbtk_eval {exp} {
- debug $exp
- set ret [catch {gdb_cmd "p/x $exp"} val]
- if {$ret} {
- return ""
- }
-
- debug "val=\"$val\""
- # response looks like "$1 = value\n"
- set ind [string first "=" $val]
- if { $ind == -1 } { return "" }
- set val [string range $val [expr $ind + 1] [string length $val]]
- set val [string trimleft $val]
- set val [string trimright $val "\n"]
- debug "returning \"$val\""
- return $val
-}
\ No newline at end of file
--
Martin Hunt
GDB Engineer
Red Hat, Inc.
next prev parent reply other threads:[~2001-11-30 23:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-10-05 17:00 Andrew Cagney
2001-10-05 17:41 ` Martin M. Hunt [this message]
2001-11-30 15:36 ` Martin M. Hunt
2001-11-30 15:05 ` Andrew Cagney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200111302335.PAA01234@cygnus.com \
--to=hunt@redhat.com \
--cc=ac131313@cygnus.com \
--cc=insight@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).