public inbox for insight@sourceware.org
 help / color / mirror / Atom feed
From: Ian Roxborough <irox@redhat.com>
To: insight@sources.redhat.com
Subject: [Patch] Prefs error...
Date: Thu, 11 Oct 2001 12:21:00 -0000	[thread overview]
Message-ID: <20011211004611.10d0f058.irox@redhat.com> (raw)


Hi,

I came across this problem with the prefs.
Keith has approved this fix offline.

How to reproduce:

The problem occurs when running Insight for the
second time when connecting to a remote board via
a serial line.

Steps:
1- Delete your ~/.gdbtk file.
2- Launch Insight.
3- Load the program to debug (file menu -> "Open...")
4- Click on the "blue man" and the target selection
   dialog should appear.
5- Set your target selection settings (serial port, etc.)
   and click on the OK button.
6- Everything should work fine.
7- Exit Insight.
8- Launch Insight again.
9- Load the program again.
10- Click on the blue man and you should see the error
    dialog.

The "default-hostname" preference is PREF_defined in the
target settings dialog's initialization code.  If this code
isn't called then when these preference are accessed they
will cause an error.

The patch fixes the problem by using "pref getd" which
will define non-existant preference rather than popup
an error dialog.

Ian.

ChangeLog:
2001-12-10  Ian Roxborough  <irox@redhat.com>

        * library/interface.tcl (set_target_name): Call "pref getd"
        instead of "pref get" to avoid undefined preference error
        message for default-hostname.

Index: library/interface.tcl
===================================================================
RCS file: /cvs/src/src/gdb/gdbtk/library/interface.tcl,v
retrieving revision 1.34
diff -r1.34 interface.tcl
1042c1042
< 	set hostname [pref get gdb/load/default-hostname]
---
> 	set hostname [pref getd gdb/load/default-hostname]

WARNING: multiple messages have this Message-ID
From: Ian Roxborough <irox@redhat.com>
To: insight@sources.redhat.com
Subject: [Patch] Prefs error...
Date: Tue, 11 Dec 2001 00:50:00 -0000	[thread overview]
Message-ID: <20011211004611.10d0f058.irox@redhat.com> (raw)
Message-ID: <20011211005000.FuMQFHivADJSa0EZ0gHk83RlK181j3uifjyccYyE9q4@z> (raw)

Hi,

I came across this problem with the prefs.
Keith has approved this fix offline.

How to reproduce:

The problem occurs when running Insight for the
second time when connecting to a remote board via
a serial line.

Steps:
1- Delete your ~/.gdbtk file.
2- Launch Insight.
3- Load the program to debug (file menu -> "Open...")
4- Click on the "blue man" and the target selection
   dialog should appear.
5- Set your target selection settings (serial port, etc.)
   and click on the OK button.
6- Everything should work fine.
7- Exit Insight.
8- Launch Insight again.
9- Load the program again.
10- Click on the blue man and you should see the error
    dialog.

The "default-hostname" preference is PREF_defined in the
target settings dialog's initialization code.  If this code
isn't called then when these preference are accessed they
will cause an error.

The patch fixes the problem by using "pref getd" which
will define non-existant preference rather than popup
an error dialog.

Ian.

ChangeLog:
2001-12-10  Ian Roxborough  <irox@redhat.com>

        * library/interface.tcl (set_target_name): Call "pref getd"
        instead of "pref get" to avoid undefined preference error
        message for default-hostname.

Index: library/interface.tcl
===================================================================
RCS file: /cvs/src/src/gdb/gdbtk/library/interface.tcl,v
retrieving revision 1.34
diff -r1.34 interface.tcl
1042c1042
< 	set hostname [pref get gdb/load/default-hostname]
---
> 	set hostname [pref getd gdb/load/default-hostname]

             reply	other threads:[~2001-12-11  8:50 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2001-10-11 12:21 Ian Roxborough [this message]
2001-12-11  0:50 ` Ian Roxborough

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20011211004611.10d0f058.irox@redhat.com \
    --to=irox@redhat.com \
    --cc=insight@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).