* [RFA] Address, line number, d/l progress bar UI patch.
@ 2001-10-11 21:58 Ian Roxborough
2001-10-12 7:22 ` Ian Roxborough
2001-12-11 1:43 ` Ian Roxborough
0 siblings, 2 replies; 4+ messages in thread
From: Ian Roxborough @ 2001-10-11 21:58 UTC (permalink / raw)
To: insight
Hi,
this is the UI patch I submitted earlier. It moves the address,
line number and download progressmeter on to the status bar.
I think I had approval to check this in at one point, but I've
made some changes to carry the 64-bit addresses display fix over
into srcwin.itb. No major changes, but since it's been a few weeks
I thought I'd run it by everybody again.
Thanks,
Ian.
ChangeLog:
2001-10-15 Ian Roxborough <irox@redhat.com>
* library/srcbar.itcl (SrcBar::create_buttons): Line number
and address fields have been removed and added to the
status bar.
* library/srcwin.itb (SrcWin::_build_win): Add address and
line number fields to status bar. Moved download progress
bar to status bar.
(SrcWin::download_progress): Use canvas on status bar.
Remember to adjust width of 64-bit address.
(SrcWin::location): Set line number and address on status bar.
* library/srcwin.ith (SrcWin): Added new private variable.
Index: srcbar.itcl
===================================================================
RCS file: /cvs/src/src/gdb/gdbtk/library/srcbar.itcl,v
retrieving revision 1.13
diff -r1.13 srcbar.itcl
537,542d536
< $Tool add label addr $address "Address" -relief sunken \
< -bd 1 -anchor e -font src-font
<
< $Tool add label line $line "Line Number" -width 6 -relief sunken \
< -bd 1 -anchor e -font src-font
<
1168,1184d1161
< }
<
< # This holds the text that is shown in the address label.
< public variable address {} {
< if {[string length $address] > 10} {
< # 64-bit address plus "0x"
< set width 18
< } else {
< # 32-bit address plus "0x"
< set width 10
< }
< $Tool itemconfigure addr -text $address -font src-font -width $width
< }
<
< # This holds the text that is shown in the line label.
< public variable line {} {
< $Tool itemconfigure line -text $line
Index: srcwin.itb
===================================================================
RCS file: /cvs/src/src/gdb/gdbtk/library/srcwin.itb,v
retrieving revision 1.18
diff -r1.18 srcwin.itb
114,115c114
<
< # Search/download progress frame
---
> # Search
122,125d120
< canvas $_statbar.frame.progress -relief sunken -borderwidth 2 \
< -highlightthickness 0 -takefocus 0 -width 100 -height 0 -confine 1
< $_statbar.frame.progress create rectangle 0 0 0 \
< [winfo height $_statbar.frame.progress] -outline blue -fill blue -tags rect
142a138,139
> set _statusframe [frame $_status]
> set _status $_statusframe.con
144c141,163
< pack $_status -expand 1 -fill both
---
>
> # add download progress meter
> canvas $_statusframe.progress -relief sunken -borderwidth 2 \
> -highlightthickness 0 -takefocus 0 -width 100 -height 0 -confine 1
> $_statusframe.progress create rectangle 0 0 0 \
> [winfo height $_statusframe.progress] -outline blue -fill blue -tags rect
>
> # add address and line number indicators
> label $_statusframe.addr -text "" -width 10 -relief sunken \
> -bd 1 -anchor e -font src-font
> label $_statusframe.line -text "" -width 6 -relief sunken \
> -bd 1 -anchor e -font src-font
>
> balloon register $_statusframe.addr "Address"
> balloon register $_statusframe.line "Line number"
>
> pack $_statusframe -expand 1 -fill both
> grid $_status -row 0 -column 1 -sticky news -pady 2 -padx 2
> grid $_statusframe.addr -row 0 -column 3 -sticky nes -pady 4
> grid $_statusframe.line -row 0 -column 4 -sticky nws -pady 4
> grid columnconfigure $_statusframe 1 -weight 10
> grid columnconfigure $_statusframe 2 -minsize 5
> grid columnconfigure $_statusframe 5 -minsize 5
209,210c228,229
< pack forget $_statbar.frame.search
< pack $_statbar.frame.progress -fill both -expand yes
---
> grid forget $_statusframe.addr $_statusframe.line
> grid $_statusframe.progress -row 0 -column 4 -padx 4 -sticky news
235c254
< set canvas $_statbar.frame.progress
---
> set canvas $_statusframe.progress
262,263c281,283
< pack forget $_statbar.frame.progress
< pack $_statbar.frame.search -fill x -expand yes
---
> grid forget $_statusframe.progress
> grid $_statusframe.addr -row 0 -column 3 -sticky new -pady 4
> grid $_statusframe.line -row 0 -column 4 -sticky nws -pady 4
460c480,481
< $_toolbar configure -address $addr -line $line
---
> $_statusframe.addr configure -text $addr
> $_statusframe.line configure -text $line
Index: srcwin.ith
===================================================================
RCS file: /cvs/src/src/gdb/gdbtk/library/srcwin.ith,v
retrieving revision 1.7
diff -r1.7 srcwin.ith
81a82
> variable _statusframe
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [RFA] Address, line number, d/l progress bar UI patch.
2001-10-11 21:58 [RFA] Address, line number, d/l progress bar UI patch Ian Roxborough
@ 2001-10-12 7:22 ` Ian Roxborough
2001-12-11 11:25 ` Ian Roxborough
2001-12-11 1:43 ` Ian Roxborough
1 sibling, 1 reply; 4+ messages in thread
From: Ian Roxborough @ 2001-10-12 7:22 UTC (permalink / raw)
To: Ian Roxborough; +Cc: insight
Uptodate screen shots for those who asked:
http://people.redhat.com/irox/insight/statusbar.jpg
http://people.redhat.com/irox/insight/statusbar-loading.jpg
Ian.
On Tue, 11 Dec 2001 01:39:25 -0800 Ian Roxborough <irox@redhat.com> wrote:
>
> Hi,
>
> this is the UI patch I submitted earlier. It moves the address,
> line number and download progressmeter on to the status bar.
>
> I think I had approval to check this in at one point, but I've
> made some changes to carry the 64-bit addresses display fix over
> into srcwin.itb. No major changes, but since it's been a few weeks
> I thought I'd run it by everybody again.
>
> Thanks,
> Ian.
>
>
> ChangeLog:
> 2001-10-15 Ian Roxborough <irox@redhat.com>
>
> * library/srcbar.itcl (SrcBar::create_buttons): Line number
> and address fields have been removed and added to the
> status bar.
> * library/srcwin.itb (SrcWin::_build_win): Add address and
> line number fields to status bar. Moved download progress
> bar to status bar.
> (SrcWin::download_progress): Use canvas on status bar.
> Remember to adjust width of 64-bit address.
> (SrcWin::location): Set line number and address on status bar.
> * library/srcwin.ith (SrcWin): Added new private variable.
>
>
> Index: srcbar.itcl
> ===================================================================
> RCS file: /cvs/src/src/gdb/gdbtk/library/srcbar.itcl,v
> retrieving revision 1.13
> diff -r1.13 srcbar.itcl
> 537,542d536
> < $Tool add label addr $address "Address" -relief sunken \
> < -bd 1 -anchor e -font src-font
> <
> < $Tool add label line $line "Line Number" -width 6 -relief sunken \
> < -bd 1 -anchor e -font src-font
> <
> 1168,1184d1161
> < }
> <
> < # This holds the text that is shown in the address label.
> < public variable address {} {
> < if {[string length $address] > 10} {
> < # 64-bit address plus "0x"
> < set width 18
> < } else {
> < # 32-bit address plus "0x"
> < set width 10
> < }
> < $Tool itemconfigure addr -text $address -font src-font -width $width
> < }
> <
> < # This holds the text that is shown in the line label.
> < public variable line {} {
> < $Tool itemconfigure line -text $line
> Index: srcwin.itb
> ===================================================================
> RCS file: /cvs/src/src/gdb/gdbtk/library/srcwin.itb,v
> retrieving revision 1.18
> diff -r1.18 srcwin.itb
> 114,115c114
> <
> < # Search/download progress frame
> ---
> > # Search
> 122,125d120
> < canvas $_statbar.frame.progress -relief sunken -borderwidth 2 \
> < -highlightthickness 0 -takefocus 0 -width 100 -height 0 -confine 1
> < $_statbar.frame.progress create rectangle 0 0 0 \
> < [winfo height $_statbar.frame.progress] -outline blue -fill blue -tags rect
> 142a138,139
> > set _statusframe [frame $_status]
> > set _status $_statusframe.con
> 144c141,163
> < pack $_status -expand 1 -fill both
> ---
> >
> > # add download progress meter
> > canvas $_statusframe.progress -relief sunken -borderwidth 2 \
> > -highlightthickness 0 -takefocus 0 -width 100 -height 0 -confine 1
> > $_statusframe.progress create rectangle 0 0 0 \
> > [winfo height $_statusframe.progress] -outline blue -fill blue -tags rect
> >
> > # add address and line number indicators
> > label $_statusframe.addr -text "" -width 10 -relief sunken \
> > -bd 1 -anchor e -font src-font
> > label $_statusframe.line -text "" -width 6 -relief sunken \
> > -bd 1 -anchor e -font src-font
> >
> > balloon register $_statusframe.addr "Address"
> > balloon register $_statusframe.line "Line number"
> >
> > pack $_statusframe -expand 1 -fill both
> > grid $_status -row 0 -column 1 -sticky news -pady 2 -padx 2
> > grid $_statusframe.addr -row 0 -column 3 -sticky nes -pady 4
> > grid $_statusframe.line -row 0 -column 4 -sticky nws -pady 4
> > grid columnconfigure $_statusframe 1 -weight 10
> > grid columnconfigure $_statusframe 2 -minsize 5
> > grid columnconfigure $_statusframe 5 -minsize 5
> 209,210c228,229
> < pack forget $_statbar.frame.search
> < pack $_statbar.frame.progress -fill both -expand yes
> ---
> > grid forget $_statusframe.addr $_statusframe.line
> > grid $_statusframe.progress -row 0 -column 4 -padx 4 -sticky news
> 235c254
> < set canvas $_statbar.frame.progress
> ---
> > set canvas $_statusframe.progress
> 262,263c281,283
> < pack forget $_statbar.frame.progress
> < pack $_statbar.frame.search -fill x -expand yes
> ---
> > grid forget $_statusframe.progress
> > grid $_statusframe.addr -row 0 -column 3 -sticky new -pady 4
> > grid $_statusframe.line -row 0 -column 4 -sticky nws -pady 4
> 460c480,481
> < $_toolbar configure -address $addr -line $line
> ---
> > $_statusframe.addr configure -text $addr
> > $_statusframe.line configure -text $line
> Index: srcwin.ith
> ===================================================================
> RCS file: /cvs/src/src/gdb/gdbtk/library/srcwin.ith,v
> retrieving revision 1.7
> diff -r1.7 srcwin.ith
> 81a82
> > variable _statusframe
^ permalink raw reply [flat|nested] 4+ messages in thread
* [RFA] Address, line number, d/l progress bar UI patch.
2001-10-11 21:58 [RFA] Address, line number, d/l progress bar UI patch Ian Roxborough
2001-10-12 7:22 ` Ian Roxborough
@ 2001-12-11 1:43 ` Ian Roxborough
1 sibling, 0 replies; 4+ messages in thread
From: Ian Roxborough @ 2001-12-11 1:43 UTC (permalink / raw)
To: insight
Hi,
this is the UI patch I submitted earlier. It moves the address,
line number and download progressmeter on to the status bar.
I think I had approval to check this in at one point, but I've
made some changes to carry the 64-bit addresses display fix over
into srcwin.itb. No major changes, but since it's been a few weeks
I thought I'd run it by everybody again.
Thanks,
Ian.
ChangeLog:
2001-10-15 Ian Roxborough <irox@redhat.com>
* library/srcbar.itcl (SrcBar::create_buttons): Line number
and address fields have been removed and added to the
status bar.
* library/srcwin.itb (SrcWin::_build_win): Add address and
line number fields to status bar. Moved download progress
bar to status bar.
(SrcWin::download_progress): Use canvas on status bar.
Remember to adjust width of 64-bit address.
(SrcWin::location): Set line number and address on status bar.
* library/srcwin.ith (SrcWin): Added new private variable.
Index: srcbar.itcl
===================================================================
RCS file: /cvs/src/src/gdb/gdbtk/library/srcbar.itcl,v
retrieving revision 1.13
diff -r1.13 srcbar.itcl
537,542d536
< $Tool add label addr $address "Address" -relief sunken \
< -bd 1 -anchor e -font src-font
<
< $Tool add label line $line "Line Number" -width 6 -relief sunken \
< -bd 1 -anchor e -font src-font
<
1168,1184d1161
< }
<
< # This holds the text that is shown in the address label.
< public variable address {} {
< if {[string length $address] > 10} {
< # 64-bit address plus "0x"
< set width 18
< } else {
< # 32-bit address plus "0x"
< set width 10
< }
< $Tool itemconfigure addr -text $address -font src-font -width $width
< }
<
< # This holds the text that is shown in the line label.
< public variable line {} {
< $Tool itemconfigure line -text $line
Index: srcwin.itb
===================================================================
RCS file: /cvs/src/src/gdb/gdbtk/library/srcwin.itb,v
retrieving revision 1.18
diff -r1.18 srcwin.itb
114,115c114
<
< # Search/download progress frame
---
> # Search
122,125d120
< canvas $_statbar.frame.progress -relief sunken -borderwidth 2 \
< -highlightthickness 0 -takefocus 0 -width 100 -height 0 -confine 1
< $_statbar.frame.progress create rectangle 0 0 0 \
< [winfo height $_statbar.frame.progress] -outline blue -fill blue -tags rect
142a138,139
> set _statusframe [frame $_status]
> set _status $_statusframe.con
144c141,163
< pack $_status -expand 1 -fill both
---
>
> # add download progress meter
> canvas $_statusframe.progress -relief sunken -borderwidth 2 \
> -highlightthickness 0 -takefocus 0 -width 100 -height 0 -confine 1
> $_statusframe.progress create rectangle 0 0 0 \
> [winfo height $_statusframe.progress] -outline blue -fill blue -tags rect
>
> # add address and line number indicators
> label $_statusframe.addr -text "" -width 10 -relief sunken \
> -bd 1 -anchor e -font src-font
> label $_statusframe.line -text "" -width 6 -relief sunken \
> -bd 1 -anchor e -font src-font
>
> balloon register $_statusframe.addr "Address"
> balloon register $_statusframe.line "Line number"
>
> pack $_statusframe -expand 1 -fill both
> grid $_status -row 0 -column 1 -sticky news -pady 2 -padx 2
> grid $_statusframe.addr -row 0 -column 3 -sticky nes -pady 4
> grid $_statusframe.line -row 0 -column 4 -sticky nws -pady 4
> grid columnconfigure $_statusframe 1 -weight 10
> grid columnconfigure $_statusframe 2 -minsize 5
> grid columnconfigure $_statusframe 5 -minsize 5
209,210c228,229
< pack forget $_statbar.frame.search
< pack $_statbar.frame.progress -fill both -expand yes
---
> grid forget $_statusframe.addr $_statusframe.line
> grid $_statusframe.progress -row 0 -column 4 -padx 4 -sticky news
235c254
< set canvas $_statbar.frame.progress
---
> set canvas $_statusframe.progress
262,263c281,283
< pack forget $_statbar.frame.progress
< pack $_statbar.frame.search -fill x -expand yes
---
> grid forget $_statusframe.progress
> grid $_statusframe.addr -row 0 -column 3 -sticky new -pady 4
> grid $_statusframe.line -row 0 -column 4 -sticky nws -pady 4
460c480,481
< $_toolbar configure -address $addr -line $line
---
> $_statusframe.addr configure -text $addr
> $_statusframe.line configure -text $line
Index: srcwin.ith
===================================================================
RCS file: /cvs/src/src/gdb/gdbtk/library/srcwin.ith,v
retrieving revision 1.7
diff -r1.7 srcwin.ith
81a82
> variable _statusframe
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [RFA] Address, line number, d/l progress bar UI patch.
2001-10-12 7:22 ` Ian Roxborough
@ 2001-12-11 11:25 ` Ian Roxborough
0 siblings, 0 replies; 4+ messages in thread
From: Ian Roxborough @ 2001-12-11 11:25 UTC (permalink / raw)
To: Ian Roxborough; +Cc: insight
Uptodate screen shots for those who asked:
http://people.redhat.com/irox/insight/statusbar.jpg
http://people.redhat.com/irox/insight/statusbar-loading.jpg
Ian.
On Tue, 11 Dec 2001 01:39:25 -0800 Ian Roxborough <irox@redhat.com> wrote:
>
> Hi,
>
> this is the UI patch I submitted earlier. It moves the address,
> line number and download progressmeter on to the status bar.
>
> I think I had approval to check this in at one point, but I've
> made some changes to carry the 64-bit addresses display fix over
> into srcwin.itb. No major changes, but since it's been a few weeks
> I thought I'd run it by everybody again.
>
> Thanks,
> Ian.
>
>
> ChangeLog:
> 2001-10-15 Ian Roxborough <irox@redhat.com>
>
> * library/srcbar.itcl (SrcBar::create_buttons): Line number
> and address fields have been removed and added to the
> status bar.
> * library/srcwin.itb (SrcWin::_build_win): Add address and
> line number fields to status bar. Moved download progress
> bar to status bar.
> (SrcWin::download_progress): Use canvas on status bar.
> Remember to adjust width of 64-bit address.
> (SrcWin::location): Set line number and address on status bar.
> * library/srcwin.ith (SrcWin): Added new private variable.
>
>
> Index: srcbar.itcl
> ===================================================================
> RCS file: /cvs/src/src/gdb/gdbtk/library/srcbar.itcl,v
> retrieving revision 1.13
> diff -r1.13 srcbar.itcl
> 537,542d536
> < $Tool add label addr $address "Address" -relief sunken \
> < -bd 1 -anchor e -font src-font
> <
> < $Tool add label line $line "Line Number" -width 6 -relief sunken \
> < -bd 1 -anchor e -font src-font
> <
> 1168,1184d1161
> < }
> <
> < # This holds the text that is shown in the address label.
> < public variable address {} {
> < if {[string length $address] > 10} {
> < # 64-bit address plus "0x"
> < set width 18
> < } else {
> < # 32-bit address plus "0x"
> < set width 10
> < }
> < $Tool itemconfigure addr -text $address -font src-font -width $width
> < }
> <
> < # This holds the text that is shown in the line label.
> < public variable line {} {
> < $Tool itemconfigure line -text $line
> Index: srcwin.itb
> ===================================================================
> RCS file: /cvs/src/src/gdb/gdbtk/library/srcwin.itb,v
> retrieving revision 1.18
> diff -r1.18 srcwin.itb
> 114,115c114
> <
> < # Search/download progress frame
> ---
> > # Search
> 122,125d120
> < canvas $_statbar.frame.progress -relief sunken -borderwidth 2 \
> < -highlightthickness 0 -takefocus 0 -width 100 -height 0 -confine 1
> < $_statbar.frame.progress create rectangle 0 0 0 \
> < [winfo height $_statbar.frame.progress] -outline blue -fill blue -tags rect
> 142a138,139
> > set _statusframe [frame $_status]
> > set _status $_statusframe.con
> 144c141,163
> < pack $_status -expand 1 -fill both
> ---
> >
> > # add download progress meter
> > canvas $_statusframe.progress -relief sunken -borderwidth 2 \
> > -highlightthickness 0 -takefocus 0 -width 100 -height 0 -confine 1
> > $_statusframe.progress create rectangle 0 0 0 \
> > [winfo height $_statusframe.progress] -outline blue -fill blue -tags rect
> >
> > # add address and line number indicators
> > label $_statusframe.addr -text "" -width 10 -relief sunken \
> > -bd 1 -anchor e -font src-font
> > label $_statusframe.line -text "" -width 6 -relief sunken \
> > -bd 1 -anchor e -font src-font
> >
> > balloon register $_statusframe.addr "Address"
> > balloon register $_statusframe.line "Line number"
> >
> > pack $_statusframe -expand 1 -fill both
> > grid $_status -row 0 -column 1 -sticky news -pady 2 -padx 2
> > grid $_statusframe.addr -row 0 -column 3 -sticky nes -pady 4
> > grid $_statusframe.line -row 0 -column 4 -sticky nws -pady 4
> > grid columnconfigure $_statusframe 1 -weight 10
> > grid columnconfigure $_statusframe 2 -minsize 5
> > grid columnconfigure $_statusframe 5 -minsize 5
> 209,210c228,229
> < pack forget $_statbar.frame.search
> < pack $_statbar.frame.progress -fill both -expand yes
> ---
> > grid forget $_statusframe.addr $_statusframe.line
> > grid $_statusframe.progress -row 0 -column 4 -padx 4 -sticky news
> 235c254
> < set canvas $_statbar.frame.progress
> ---
> > set canvas $_statusframe.progress
> 262,263c281,283
> < pack forget $_statbar.frame.progress
> < pack $_statbar.frame.search -fill x -expand yes
> ---
> > grid forget $_statusframe.progress
> > grid $_statusframe.addr -row 0 -column 3 -sticky new -pady 4
> > grid $_statusframe.line -row 0 -column 4 -sticky nws -pady 4
> 460c480,481
> < $_toolbar configure -address $addr -line $line
> ---
> > $_statusframe.addr configure -text $addr
> > $_statusframe.line configure -text $line
> Index: srcwin.ith
> ===================================================================
> RCS file: /cvs/src/src/gdb/gdbtk/library/srcwin.ith,v
> retrieving revision 1.7
> diff -r1.7 srcwin.ith
> 81a82
> > variable _statusframe
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2001-12-11 19:25 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2001-10-11 21:58 [RFA] Address, line number, d/l progress bar UI patch Ian Roxborough
2001-10-12 7:22 ` Ian Roxborough
2001-12-11 11:25 ` Ian Roxborough
2001-12-11 1:43 ` Ian Roxborough
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).