* xlib/X11/Xutil.h patch: XEmptyRegion
@ 2002-01-23 14:29 DJ Delorie
2002-01-23 15:27 ` Ian Roxborough
2002-01-24 19:29 ` Ian Roxborough
0 siblings, 2 replies; 5+ messages in thread
From: DJ Delorie @ 2002-01-23 14:29 UTC (permalink / raw)
To: insight; +Cc: dj
The book says bool, and tk/unix/tkUnixDraw.c assumes Bool also.
2002-01-23 DJ Delorie <dj@redhat.com>
* xlib/X11/Xutil.h (XEmptyRegion): Returns Bool.
Index: xlib/X11/Xutil.h
===================================================================
RCS file: /cvs/uberbaum/tk/xlib/X11/Xutil.h,v
retrieving revision 1.2
diff -p -3 -r1.2 Xutil.h
*** Xutil.h 2001/09/10 01:16:55 1.2
--- Xutil.h 2002/01/23 22:27:53
*************** extern void XDestroyRegion(
*** 364,370 ****
#endif
);
! extern void XEmptyRegion(
#if NeedFunctionPrototypes
Region /* r */
#endif
--- 364,370 ----
#endif
);
! extern Bool XEmptyRegion(
#if NeedFunctionPrototypes
Region /* r */
#endif
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: xlib/X11/Xutil.h patch: XEmptyRegion
2002-01-23 14:29 xlib/X11/Xutil.h patch: XEmptyRegion DJ Delorie
@ 2002-01-23 15:27 ` Ian Roxborough
2002-01-23 16:06 ` DJ Delorie
2002-01-24 19:29 ` Ian Roxborough
1 sibling, 1 reply; 5+ messages in thread
From: Ian Roxborough @ 2002-01-23 15:27 UTC (permalink / raw)
To: DJ Delorie; +Cc: insight
Hi,
actaully, now that you mention it, they seems to be quite a few
functions with this problem. Your fix looks right but I'll have
a scout around and make sure that there not all ment to be that way
for some strange reason.
Do you see any value in changing them all or is it just this one
that is causing problems?
Thanks,
Ian.
On Wed, 23 Jan 2002 17:29:29 -0500 DJ Delorie <dj@redhat.com> wrote:
>
>
> The book says bool, and tk/unix/tkUnixDraw.c assumes Bool also.
>
> 2002-01-23 DJ Delorie <dj@redhat.com>
>
> * xlib/X11/Xutil.h (XEmptyRegion): Returns Bool.
>
> Index: xlib/X11/Xutil.h
> ===================================================================
> RCS file: /cvs/uberbaum/tk/xlib/X11/Xutil.h,v
> retrieving revision 1.2
> diff -p -3 -r1.2 Xutil.h
> *** Xutil.h 2001/09/10 01:16:55 1.2
> --- Xutil.h 2002/01/23 22:27:53
> *************** extern void XDestroyRegion(
> *** 364,370 ****
> #endif
> );
>
> ! extern void XEmptyRegion(
> #if NeedFunctionPrototypes
> Region /* r */
> #endif
> --- 364,370 ----
> #endif
> );
>
> ! extern Bool XEmptyRegion(
> #if NeedFunctionPrototypes
> Region /* r */
> #endif
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: xlib/X11/Xutil.h patch: XEmptyRegion
2002-01-23 15:27 ` Ian Roxborough
@ 2002-01-23 16:06 ` DJ Delorie
0 siblings, 0 replies; 5+ messages in thread
From: DJ Delorie @ 2002-01-23 16:06 UTC (permalink / raw)
To: irox; +Cc: insight
> Do you see any value in changing them all or is it just this one
> that is causing problems?
This particular one is causing problems on our sparc64 build, because
these headers get used for the build, and as noted
tk/unix/tkUnixDraw.c fails to build because of the header bug.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: xlib/X11/Xutil.h patch: XEmptyRegion
2002-01-23 14:29 xlib/X11/Xutil.h patch: XEmptyRegion DJ Delorie
2002-01-23 15:27 ` Ian Roxborough
@ 2002-01-24 19:29 ` Ian Roxborough
2002-01-24 19:34 ` DJ Delorie
1 sibling, 1 reply; 5+ messages in thread
From: Ian Roxborough @ 2002-01-24 19:29 UTC (permalink / raw)
To: DJ Delorie; +Cc: insight
Works fine for me. Please check it in.
Thanks,
Ian.
On Wed, 23 Jan 2002 17:29:29 -0500 DJ Delorie <dj@redhat.com> wrote:
>
>
> The book says bool, and tk/unix/tkUnixDraw.c assumes Bool also.
>
> 2002-01-23 DJ Delorie <dj@redhat.com>
>
> * xlib/X11/Xutil.h (XEmptyRegion): Returns Bool.
>
> Index: xlib/X11/Xutil.h
> ===================================================================
> RCS file: /cvs/uberbaum/tk/xlib/X11/Xutil.h,v
> retrieving revision 1.2
> diff -p -3 -r1.2 Xutil.h
> *** Xutil.h 2001/09/10 01:16:55 1.2
> --- Xutil.h 2002/01/23 22:27:53
> *************** extern void XDestroyRegion(
> *** 364,370 ****
> #endif
> );
>
> ! extern void XEmptyRegion(
> #if NeedFunctionPrototypes
> Region /* r */
> #endif
> --- 364,370 ----
> #endif
> );
>
> ! extern Bool XEmptyRegion(
> #if NeedFunctionPrototypes
> Region /* r */
> #endif
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: xlib/X11/Xutil.h patch: XEmptyRegion
2002-01-24 19:29 ` Ian Roxborough
@ 2002-01-24 19:34 ` DJ Delorie
0 siblings, 0 replies; 5+ messages in thread
From: DJ Delorie @ 2002-01-24 19:34 UTC (permalink / raw)
To: irox; +Cc: insight
Done. Thanks!
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2002-01-25 3:34 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2002-01-23 14:29 xlib/X11/Xutil.h patch: XEmptyRegion DJ Delorie
2002-01-23 15:27 ` Ian Roxborough
2002-01-23 16:06 ` DJ Delorie
2002-01-24 19:29 ` Ian Roxborough
2002-01-24 19:34 ` DJ Delorie
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).