public inbox for insight@sourceware.org
 help / color / mirror / Atom feed
From: "Martin M. Hunt" <hunt@redhat.com>
To: insight@sources.redhat.com
Subject: [patch] fix memory window sizing
Date: Thu, 10 Oct 2002 16:56:00 -0000	[thread overview]
Message-ID: <200210101655.39311.hunt@redhat.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 303 bytes --]

Memory window was not resizing correctly because gdb_update_mem()
was not returning column sizes.

-- 
Martin Hunt
GDB Engineer
Red Hat, Inc.

2002-10-10  Martin M. Hunt  <hunt@redhat.com>

	* generic/gdbtk-cmds.c (gdb_update_mem): No results
	were being returned. Append results to result_ptr_obj_ptr.

[-- Attachment #2: p --]
[-- Type: text/x-diff, Size: 1118 bytes --]

Index: generic/gdbtk-cmds.c
===================================================================
RCS file: /cvs/src/src/gdb/gdbtk/generic/gdbtk-cmds.c,v
retrieving revision 1.57
diff -u -p -r1.57 gdbtk-cmds.c
--- generic/gdbtk-cmds.c	16 May 2002 01:08:51 -0000	1.57
+++ generic/gdbtk-cmds.c	10 Oct 2002 23:55:06 -0000
@@ -2703,12 +2703,9 @@ gdb_update_mem (ClientData clientData, T
     }
 
   /* return max_*_len so that column widths can be set */
-  result = Tcl_NewListObj (0, NULL);
-  Tcl_ListObjAppendElement (interp, result, Tcl_NewIntObj (max_label_len + 1));
-  Tcl_ListObjAppendElement (interp, result, Tcl_NewIntObj (max_val_len + 1));
-  Tcl_ListObjAppendElement (interp, result, Tcl_NewIntObj (max_ascii_len + 1));
-  result_ptr->flags |= GDBTK_IN_TCL_RESULT;
-
+  Tcl_ListObjAppendElement (interp, result_ptr->obj_ptr, Tcl_NewIntObj (max_label_len + 1));
+  Tcl_ListObjAppendElement (interp, result_ptr->obj_ptr, Tcl_NewIntObj (max_val_len + 1));
+  Tcl_ListObjAppendElement (interp, result_ptr->obj_ptr, Tcl_NewIntObj (max_ascii_len + 1));
   do_cleanups (old_chain);
   xfree (mbuf);
   return TCL_OK;

                 reply	other threads:[~2002-10-10 23:56 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200210101655.39311.hunt@redhat.com \
    --to=hunt@redhat.com \
    --cc=insight@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).