public inbox for insight@sourceware.org
 help / color / mirror / Atom feed
* build failure patch: gdbtk-hooks.c
@ 2004-04-19  4:08 Ben Elliston
  2004-04-19 18:40 ` Roland McGrath
  0 siblings, 1 reply; 2+ messages in thread
From: Ben Elliston @ 2004-04-19  4:08 UTC (permalink / raw)
  To: insight; +Cc: roland

I think Roland may have constified the wrong function declaration?

Ben

2004-04-19  Ben Elliston  <bje@au.ibm.com>

	* generic/gdbtk-hooks.c (gdbtk_pre_add_symbol): Similarly, add
	const to argument type in declaration.

Index: generic/gdbtk-hooks.c
===================================================================
RCS file: /cvs/src/src/gdb/gdbtk/generic/gdbtk-hooks.c,v
retrieving revision 1.32
diff -u -p -r1.32 gdbtk-hooks.c
--- generic/gdbtk-hooks.c	15 Apr 2004 21:39:35 -0000	1.32
+++ generic/gdbtk-hooks.c	19 Apr 2004 04:06:23 -0000
@@ -93,7 +93,7 @@ static void gdbtk_warning (const char *,
 static char *gdbtk_readline (char *);
 static void gdbtk_readline_begin (char *format,...);
 static void gdbtk_readline_end (void);
-static void gdbtk_pre_add_symbol (char *);
+static void gdbtk_pre_add_symbol (const char *);
 static void gdbtk_print_frame_info (struct symtab *, int, int, int);
 static void gdbtk_post_add_symbol (void);
 static void gdbtk_register_changed (int regno);
        

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: build failure patch: gdbtk-hooks.c
  2004-04-19  4:08 build failure patch: gdbtk-hooks.c Ben Elliston
@ 2004-04-19 18:40 ` Roland McGrath
  0 siblings, 0 replies; 2+ messages in thread
From: Roland McGrath @ 2004-04-19 18:40 UTC (permalink / raw)
  To: Ben Elliston; +Cc: insight

> I think Roland may have constified the wrong function declaration?

Nope, I just missed one decl.  Your additional fix is all that's needed,
please put it in.

> Ben
> 
> 2004-04-19  Ben Elliston  <bje@au.ibm.com>
> 
> 	* generic/gdbtk-hooks.c (gdbtk_pre_add_symbol): Similarly, add
> 	const to argument type in declaration.
> 
> Index: generic/gdbtk-hooks.c
> ===================================================================
> RCS file: /cvs/src/src/gdb/gdbtk/generic/gdbtk-hooks.c,v
> retrieving revision 1.32
> diff -u -p -r1.32 gdbtk-hooks.c
> --- generic/gdbtk-hooks.c	15 Apr 2004 21:39:35 -0000	1.32
> +++ generic/gdbtk-hooks.c	19 Apr 2004 04:06:23 -0000
> @@ -93,7 +93,7 @@ static void gdbtk_warning (const char *,
>  static char *gdbtk_readline (char *);
>  static void gdbtk_readline_begin (char *format,...);
>  static void gdbtk_readline_end (void);
> -static void gdbtk_pre_add_symbol (char *);
> +static void gdbtk_pre_add_symbol (const char *);
>  static void gdbtk_print_frame_info (struct symtab *, int, int, int);
>  static void gdbtk_post_add_symbol (void);
>  static void gdbtk_register_changed (int regno);
>         


Thanks,
Roland

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2004-04-19 18:40 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2004-04-19  4:08 build failure patch: gdbtk-hooks.c Ben Elliston
2004-04-19 18:40 ` Roland McGrath

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).