public inbox for insight@sourceware.org
 help / color / mirror / Atom feed
From: Ruppert <dieter_ruppert@siemens.com>
To: insight@sourceware.org
Cc: dieter_ruppert@siemens.com
Subject: small bug in memory window
Date: Wed, 06 Jul 2005 09:36:00 -0000	[thread overview]
Message-ID: <200507060935.j669Zkd22389@haiti.swb.siemens.de> (raw)


Hi,

we noticed a small bug in Insight's memory window: when the
display format is changed, (from "Word" to "Byte", for example),
the address displayed resets back to the default (which is
usually the start of the .data section).

I looked at the code in memwin.itb, and the reason seems obvious:
the member variable MemWin::addr_exp is never updated (after being
initialized to .data). MemWin::reconfig, which is called after 
a format change, uses this value, and therefore resets the address
to the default.

A simple one-line change fixes this; I include a small patch below.
BTW: this was Insight from gdb-6.1, but memwin.itb apparently hasn't 
changed since then.


Best Regards
Dieter Ruppert




*** memwin.itb          Wed Jul  6 11:04:41 2005
--- memwin.itb.new      Wed Jul  6 11:06:34 2005
***************
*** 512,517 ****
--- 512,519 ----
      incr index -1
      set current_addr [string range $current_addr 0 $index]
    }
+ 
+   set MemWin::addr_exp $addr_exp
    
    # set table background
    $itk_component(table) config -bg $::Colors(textbg) -state normal


                 reply	other threads:[~2005-07-06  9:36 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200507060935.j669Zkd22389@haiti.swb.siemens.de \
    --to=dieter_ruppert@siemens.com \
    --cc=insight@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).