Re: [PATCH] Rotate ChangeLog, fix build issues

[Kevin Buettner <kevinb@redhat.com>]

> 2011-04-08  Keith Seitz  <keiths@redhat.com>
> 
> 	* generic/gdbtk-bp.c (tracepoint_exists): Remove recently
> 	removed "not_found_ptr" argument from call to decode_line_1.
> 	* generic/gdbtk-stack.c (gdb_get_vars_command): Likewise.
> 	* generic/gdbtk-cmds.c (gdb_get_line_command): Likewise.
> 	(gdb_get_file_command): Likewise.
> 	(gdb_get_function_command): Likewise.

Was this actually committed?

I was about to post a similar patch, but then noticed that you had
already posted it.  (Don't see it committed though.)


In addition to the above, I do have one other change which avoids
an error along the lines of `buffer' being used before being initalized
in gdbtk-register.c's get_register().  It appears that valaddr was added
with the intention of replacing buffer[], but the switch from one to
the other (where buffer is used) was forgotten about.

Here's that change:

	* gdbtk-register.c (get_register): Delete declaration of `buffer'.
	Use `valaddr' in its place.

Index: gdbtk/generic/gdbtk-register.c
===================================================================
RCS file: /cvs/src/src/gdb/gdbtk/generic/gdbtk-register.c,v
retrieving revision 1.40
diff -u -p -r1.40 gdbtk-register.c
--- gdbtk/generic/gdbtk-register.c	8 Apr 2011 23:32:42 -0000	1.40
+++ gdbtk/generic/gdbtk-register.c	12 Apr 2011 00:08:28 -0000
@@ -276,7 +276,6 @@ get_register (int regnum, map_arg arg)
   CORE_ADDR addr;
   enum lval_type lval;
   struct type *reg_vtype;
-  gdb_byte buffer[MAX_REGISTER_SIZE];
   int format;
   struct cleanup *old_chain = NULL;
   struct ui_file *stb;
@@ -330,7 +329,7 @@ get_register (int regnum, map_arg arg)
 	{
 	  int idx = ((gdbarch_byte_order (gdbarch) == BFD_ENDIAN_BIG)
 		     ? j : register_size (gdbarch, regnum) - 1 - j);
-	  sprintf (ptr, "%02x", (unsigned char) buffer[idx]);
+	  sprintf (ptr, "%02x", (unsigned char) valaddr[idx]);
 	  ptr += 2;
 	}
       fputs_unfiltered (buf, stb);