set architecture sh2, causes core dump on latest build 20000305.

set architecture sh2, causes core dump on latest build 20000305.

[Robert]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain, Size: 961 bytes --]

With 
GNU gdb 20000305 
"--host=i686-pc-cygwin --target=sh-coff" 
the command "set architecture sh2", causes a core 
dump.
 
I believe it 
is because the sh_processor_type_table[] in sh-tdep.c does not include an entry 
for the sh2. Adding an entry fixes the problem.
 
The sh1 and 
sh2 processors share the same register names.
 
The following 
snippet shows the necessary changes.
 
Robert.
 
*** 
sh-tdep.bak Thu Feb 24 03:31:45 2000 --- sh-tdep.c Thu Mar 09 
17:10:05 2000 *************** *** 102,115 **** --- 102,119 
----   sh_processor_type_table[] =   {     
{       sh_reg_names, 
bfd_mach_sh     }     
,     { +     sh_reg_names, 
bfd_mach_sh2 +   } +   , +   
{       sh3_reg_names, 
bfd_mach_sh3     }     
,     {       sh3e_reg_names, 
bfd_mach_sh3e     }     
,

Re: set architecture sh2, causes core dump on latest build 20000305.

[Andrew Cagney]

> Robert wrote:
> 
> With GNU gdb 20000305 "--host=i686-pc-cygwin --target=sh-coff" the
> command "set architecture sh2", causes a core dump.

A core dump or an internal_error ?

Anyway, I've applied the patch.  Thanks!

	Andrew

> I believe it is because the sh_processor_type_table[] in sh-tdep.c
> does not include an entry for the sh2. Adding an entry fixes the
> problem.
> 
> The sh1 and sh2 processors share the same register names.
> 
> The following snippet shows the necessary changes.
> 
> Robert.
> 
> *** sh-tdep.bak Thu Feb 24 03:31:45 2000
> --- sh-tdep.c Thu Mar 09 17:10:05 2000
> ***************
> *** 102,115 ****
> --- 102,119 ----
>   sh_processor_type_table[] =
>   {
>     {
>       sh_reg_names, bfd_mach_sh
>     }
>     ,
>     {
> +     sh_reg_names, bfd_mach_sh2
> +   }
> +   ,
> +   {
>       sh3_reg_names, bfd_mach_sh3
>     }
>     ,
>     {
>       sh3e_reg_names, bfd_mach_sh3e
>     }
>     ,