Re: Patch: fixlet in gdbtk-cmds.c

[Fernando Nasser <fnasser@cygnus.com>]

Syd Polk wrote:
> 
> This looks good then.
> 
> At 02:57 PM 11/29/00 -0700, Tom Tromey wrote:
> >Syd> I would rather have a global variable for whether a gdbtk command
> >Syd> generated the error as opposed to Tcl itself rather than messing
> >Syd> with interp result flags. This is just asking to break when the
> >Syd> interp data structure is changed.
> >
> >I looked at this a bit more.
> >
> >In the code I quoted `result_ptr' is a global variable like that.
> >This isn't the intepreter or the result.
> >
> >I think this patch does what I want:
> >
> >2000-11-29  Tom Tromey  <tromey@cygnus.com>
> >
> >         * gdbtk-cmds.c (call_wrapper): Don't reset result if wrapped
> >         command returned error.
> >
> >Unfortunately, it is unclear what negative ramifications, if any, this
> >patch might have.  I'd have to consider it "dangerous".
> 
> I guess we will have to see what happens then.
> 
> >Syd> I will examine this more in a couple of weeks.
> 
> Well, I am out of town and unable to hack until late next week. Oh, well.
> 

Tom,

May I suggest that you register this possible cleanups, with your suggestions
on how to do it in the Gnats database.  As soon as one of us can take some
time to look deeply into this and have time to monitor any possible side
effects.

Thanks.

Fernando





-- 
Fernando Nasser
Red Hat Canada Ltd.                     E-Mail:  fnasser@redhat.com
2323 Yonge Street, Suite #300
Toronto, Ontario   M4P 2C9